From fdd43e7944b6d5befdba3bfb707a536f0dbcfa8b Mon Sep 17 00:00:00 2001
From: Ben Haynes <ben@rngr.org>
Date: Sat, 15 Aug 2020 08:58:19 -0400
Subject: [PATCH] creatign role/webhook titles

---
 app/src/lang/en-US/index.json                              | 5 ++---
 app/src/modules/settings/routes/roles/detail/detail.vue    | 2 +-
 app/src/modules/settings/routes/webhooks/detail/detail.vue | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/app/src/lang/en-US/index.json b/app/src/lang/en-US/index.json
index 9c06371d01..ab8a5df4b2 100644
--- a/app/src/lang/en-US/index.json
+++ b/app/src/lang/en-US/index.json
@@ -161,9 +161,6 @@
 	"mime_type": "MIME Type",
 	"filesize": "Filesize",
 
-	"editing_role": "{role} Role",
-	"adding_webhook": "Adding Webhook",
-
 	"code": "Code",
 	"loc": "No lines of {lang} | One line of {lang} | {count} lines of {lang}",
 
@@ -919,6 +916,8 @@
   "creating_item": "Creating Item",
   "creating_item_page_title": "Creating Item: {collection}",
   "creating_role": "Creating Role",
+  "editing_role": "{role} Role",
+  "creating_webhook": "Creating Webhook",
   "currently_selected": "Currently selected: {thing}",
   "database_connection_copy": "Next, we need to know how to connect to the database where this project will be managed.",
   "datatype": "Datatype",
diff --git a/app/src/modules/settings/routes/roles/detail/detail.vue b/app/src/modules/settings/routes/roles/detail/detail.vue
index d67f6239a9..57f91802cf 100644
--- a/app/src/modules/settings/routes/roles/detail/detail.vue
+++ b/app/src/modules/settings/routes/roles/detail/detail.vue
@@ -1,5 +1,5 @@
 <template>
-	<private-view :title="loading ? $t('loading') : $t('editing_role', { role: item && item.name })">
+	<private-view :title="loading ? $t('loading') : (isNew === false)? $t('editing_role', { role: item && item.name }) : $t('creating_role') ">
 		<template #headline>{{ $t('settings_permissions') }}</template>
 		<template #title-outer:prepend>
 			<v-button class="header-icon" rounded icon exact :to="`/settings/roles/`">
diff --git a/app/src/modules/settings/routes/webhooks/detail/detail.vue b/app/src/modules/settings/routes/webhooks/detail/detail.vue
index 8231a25e7e..6d418737e6 100644
--- a/app/src/modules/settings/routes/webhooks/detail/detail.vue
+++ b/app/src/modules/settings/routes/webhooks/detail/detail.vue
@@ -106,7 +106,7 @@ export default defineComponent({
 
 		const title = computed(() => {
 			if (loading.value) return i18n.t('loading');
-			if (isNew.value) return i18n.t('adding_webhook');
+			if (isNew.value) return i18n.t('creating_webhook');
 			return item.value.name;
 		});