* WIP start on migrations
* Add migration
* Don't insert if there's no rows
* Use service to read/write permissions
* Use payload service rather than itemsservice
* Start on downgrade command
* Update system data structure
* Update migrations to keep structure flat
* Remove icon from policies
* Drop policies table on downgrade
* Rearchitect migrations to structure v3
* Add down migration
* Update system fields
* Add policy to fields import
* Fix public role attachment
* Update packages/system-data/src/fields/index.ts
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
* Update packages/system-data/src/fields/policies.yaml
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
* Add nested roles
* Remove unused step
* Use two o2ms instead of m2a for attachments
* Update system data
* Implement permission policies in the API (#22384)
* Update system data structure
* Update migrations to keep structure flat
* Remove icon from policies
* Drop policies table on downgrade
* Rearchitect migrations to structure v3
* Add down migration
* Update system fields
* Add policy to fields import
* Fix public role attachment
* Update packages/system-data/src/fields/index.ts
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
* Update packages/system-data/src/fields/policies.yaml
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
* Add nested roles
* Remove unused step
* Use two o2ms instead of m2a for attachments
* Update system data
* [WIP] Start reorging permissions handling
* Setup field extraction
* Remove watch from vitest
* Finish fieldMap creation logic
* Add tests for utils
* Improve tests
* Improve coverage
* Split test and test:watch
* Continue on this fun
* [WIP] Setup processing
* Sort roles
* Restructure to util files for org
* Add missing util tests
* More tests
* Add cases/whencase to ast
* Start on injection logic
* Add tests for inject cases
* Add tests for process
* Add todo
* Organize run-ast
* Add clear method to kv
* Remove reliance on acc.perm
* Restructure permissions setup
* Drop perm from acc, add roles/policies
* Remove get-permissions in middleware
* Remove/comment use of acc.perm
* Add default roles/permissions
* Use knex
So we don't have to initialize the schema before we want to use the accountability system
* Use new fetching logic in get accountability
* Add new fetch global access utils
* Gotta redo based on new setup
* Replaced with new util
* Remove dropping of perm in acc
It's no longer there by default, so no need to remove here
* Temporarily comment out the enforce tfa check
* Update usage of fetch tree to use knex
* Don't store policies on accountability
* Feed in roles thru acc
* Bit of whitespace
* Rename role->policy
* Wreck some more stuff
Jk, this is splitting up the large get-ast-from-query function into smaller individual functions to make it easier to update the wildcard conversion to use permissions
* Add ability to lookup all allowed fields in col+ac
* Add note so I don't forget stuff which i will
* Handle null acc
* Introduce parseAst to itemsservice
* That cleans things up
* Replace checkAccess with validateAccess
* Remove checkaccess from service
* cleanup imports
* Whoops one more
* Leave crumbs for next time
* Implement most of the fn
* Fix various tests
* Start on test for fetch roles tree
* Add tests for fetch roles tree
* Fix process tests
* All. of. the. tests.
* Update uses of validateAccess
* Fix name in runAst
* Fix use of accountability in gql sub
* Deprecate authorization service
* Remove getPermissions use
* Drop old getpermissions
* Pass services
* Replace admin/app uses with fetch global
* Update fetch user count to pull from policies
* Remove broken admin existence checks
* Update min accountability
* Remove unused import
* Drop permissions override from controller
* Refactor reliance on acc.perm
* Replace usage of permissions in fields
* Replace usage of permissions in import/export
* Drop permissions use from relations
* Drop no longer used method
* Remove unused import
* fix type usage of pk in validate
* Fix default acc in user
* Replace use of permissions in utils
* Update reduceSchema in specs/gql
* Remove old share merging
* Remove empty file
* Remove outdated comment
* Use ctx objects for large param fns
* Add with-cache memoize util
* Add cache to fetchpermissions
* Update caching use in fetchRolesTree
* Add caching to fetchAllowedFieldMap
* Add more cache
* Refactor call signatures
* Move call signature updates
* Handle presets
* Update process call sig
* Prevent infinite recursion in roles tree lookup
* Use create util for acc
* Remove old checkIp
* Fix where equality operator
* Break EVERYTHING!
Jk just cleaning up the structure some more, and removing the dep injection in favor of mocking
* Fix build
* Add missing module tests
* Don't crash on missing parent
* Fix role lookup
* add missing type annotation
* use logical-OR assignment and avoid a memory allocation
* Attach admin policy in default admin creation
* Fix admin check
* Add todo for later
* rm code duplication
* fix test
it was missing the new `roles`
* add types and fix type error
policies dont [yet] have an icon
* move spread order to avoid potential future mishaps
new default keys would override the manually set keys, potentially leading to unintended behavior
* reduce allocations, add escape hatch to loop and type db-row
* Implement case/when
* Clean up comments
* Optimize perm fetching in allowed f
* Move apply case when to util fn
* Optimize fetch-allowed-fields
* Add fetch inconsistent util
* Allow nulls
* Remove obsolete getCacheKey
* Remove unused import
* Update getAccountabilityForRole test
* Update fetchGlobalAccess test with one more test case + fix other test case
* Type cleanup
* Fix "admin access means automatic app access" in fetchGlobalAccessForQuery
* Clean up and expand fetch-inconsistent-field-map.test.ts
* Test uncached functions
* Test uncached
* Remove cases usage in parse-current-level
* Only consider non-null rules in inject cases
* Fix parseCurrentLevel call
* Move service imports into functions to avoid circular imports
* Ensure that we test that an error is thrown in processAst test
* Add failing test case for flattenFilter
* Ensure uniqueness in extractPathsFromQuery
* Early exit in validatePath
* Add additional test case for process payload test
* Update validateCollectionAccess test
* Clean up validate-item-access.test.ts
* Remove redundant initializer
* Use createDefaultAccountability
* Fix fetch-user-count.test.ts
* Cleanup unused default initializer
* Add empty cases to subfilter in _relationCount
* Drop AccessService and PermissionsService usage from services
* Found some more PermissionsServices
* Fix a few more tests
* Add nested role relation
* Fix query invocation in aggregate and group queries
* Fix role property name in auth/refresh
* Add some missing relations for permissions, access and roles
* Add m2o relation from permissions to policy
* Add m2o relation access to role, user, policy
* Allow fetchPermissions to fetch all permissions and not just those limited by an action
* Add parent to Role type
* Make sure that admin users see all fields
* Add access and policies controller, add util methods to policies and access service
* Change name and description of public policy, update description of admin policy and add on delete trigger.
* Make sure access row uuids are auto generated
* optimize kvredis clear function and add a unit test
to be fair: unit test is also testing implementation details but thats a problem there in general and for future us
* Add minimal app permission and dynamic variable injection to the permission fetching
* Fix m2o collection name in extractFieldsFromChildren
* Make sure to clone permission before injecting dynamic variables
* Actually do the cloning in with withAppMinimalPermissions since people might missbehave with the permissions obtained from PermissionsService.readByQuery so it better to go the source of the problem
* Use knex transaction in createOne -> processPayload - otherwise deadlock
* Make sure to respect '*' field in allowed fields
* Fix extractFieldsFromChildren for o2m as well - classic
* Fix allowed field check in `FieldsService.readAll` to account for multiple permissions for collection+action
* Skip case/when if `allowedFields` includes '*'
* Restructure the way the current users permissions are returned
* add ability to clear all keys from memory cache
* add test for clear method
* add await to clear function
* Clear permissions caches on changes to policy attachments (directus_access) and policy updates (directus_policies) and permissions updates (directus_permissions)
* Make the public role a real role rather than a virtual one
* Inject the public role, we're it previously was `null`
* Revert adding a fix public role
* remove unused variable
* Ensure that a user without a role can still use the /me util endpoints
* Make sure that the /me endpoints always return minimal information, similar to /users/me
* Some fixes after merging main
* Update api/src/permissions/utils/with-cache.ts
Co-authored-by: Hannes Küttner <4376726+hanneskuettner@users.noreply.github.com>
* Avoid broken role query for now
* Skip related collection `parseFields` if user has no permissions
* Ensure same call order as in `convertWildcards`
* Create default admin policy and connect it in cli init command
* Remove obsolete middleware mock in app.test.ts
* Add validation against non-existent fields and collections to `validatePath`
* Split up permission and path existence validation and validate path existence for admin users as well
* Make applySearch not async
* Fix relation extraction and permissions for `$FOLLOW` fields
* Fix case when for related collections and query wrapping
* Rework user integrity checks for Auditus (#22737)
* Changes to user counting and integrity checks
* Ensure that user validation happens in both create one and create many
* Rename `checkType` to `flags`
* Update api/src/permissions/modules/validate-remaining-admin/validate-remaining-admin-count.ts
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
* Update to enum usage
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
* A few more changes to enum instead of number
* One more enum type update
* Make sure to correctly override the callback when combining options
* Clean up option type
* Update api/src/services/users.ts
Co-authored-by: ian <licitdev@gmail.com>
* Only take validation shortcut for users
We can only be sure that the deletion of users does not increase any other access types count, so in all other cases we need to verify that for example the App or API users have not increased over the limit
* Make both app and admin users count against app access limit
* Update api/src/permissions/modules/validate-remaining-admin/validate-remaining-admin-count.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* One post-merge fix, two small fixes
* Simplify flag updating and callback calling
* Changing app access in a policy only requires user limit checking, not full check
* Only the status of a created user should matter to determine if a check is neccessary
* Add count alias to count query
---------
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
* Add roles and permissions to the app (#22654)
* Initial app changes
* Fix getRelationsForField
* Add changeset
* Remove app-permissions from role settings
* Make sure access row uuids are auto generated
* Move a few things around, set up policies m2m properly
* Show roles as tree in sidebar
Change avatar field query for user
* Show user and role count in policy table
* Default to not adding app access for a policy, makes composability less annoying
* Correctly fall back to 0 for counts
* Change the structure of current user permissions
* Start bringing back the public role
* Make the public role a real role rather than a virtual one
* Revert public role changes
* Extend list-m2m to allow for very custom junction matching and a primary key of `null`
* Remove unused
* Fix public role policy update payload
* Fix app access for users without role (which is a thing now apparently)
* Make sure that the /me endpoints always return minimal information, similar to /users/me
* Tweak nav icons
* Pull policy id from constants
* Update permissions interface design to match
New design language in figma
* Some minor adjustments
- Make chip hover border more consistent
- Add "Remove" button to remove a full row of permissions, as in the UI mockup
- Fix table layout
* Clean up a few more things
* Fix `setFullAccess`
* Align collection view icons with navigation
* Don't query 'admin_access' for role
* Fix relation extraction and permissions for `$FOLLOW` fields
* Don't show `0 Items` for child rows, but `--` instead
* Make policy detail work in nested policy creating use case
* Remove unused v-icon override
* Move system collections to separate visual table
* Navigate before refresh
Prevents a flash of the previous value to be visible in the table
* Move composable to separate file
---------
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
* Optimize types
* Clone query deep
* Optimize type order
* Throw error on invalid role id
* Rename run.js -> run-ast.js
* Re-add filesizes to telemetry report collection that got lost in the merge
* Make `systemCollections` reactive
* Use one column per action to avoid unwanted shifting if some actions are not allowed at all
* Render system and custom together
* Add divider between regular and system permissions if both have elements
* Add AccessService and PoliciesService to `getService`
* Move policy global flags fetching to util
* Move collection access fetching into util
* Remove permissions for `directus_access`, `directus_permissions` and `directus_policies` from schema permissions
* use formatted-value display for name & description in roles & policies
* Rename `process.ts` to `process-ast.ts`
* Fix process-ast import after renaming
* Perform user integrity check on item deletion
* Fix first admin creation on bootstrap
* Revert "Fix first admin creation on bootstrap"
This reverts commit bf480d023c.
Will be fixed by adjusting the check in access service
* Don't perform admin integrity check if a new access row is created. Only check user limits
* Don't set an alias to the raw column value if it is wrapped in a case/when
* Correctly handle aliases when in field map and case injection
---------
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Co-authored-by: Hannes Küttner <kuettner.hannes@gmail.com>
Co-authored-by: Hannes Küttner <4376726+hanneskuettner@users.noreply.github.com>
Co-authored-by: ian <licitdev@gmail.com>
* Remove changeset of already merged PR (#22653)
* Fix multi cache subscribe call to preserve context
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
* Add max length to name for policy and role names
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
* Update app/src/modules/settings/routes/policies/collection.vue
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
* Organize settings sidebar for clarity
* Remove query limit override from access and policies controller
THe query limit was added previously, where the idea was to fetch all policies in the app, but since that is not required anymore we can remove the override again, which in turn fixed pagination for policies. Woop
* Rework MetaService
* Fix filtered counting (previously it did not account for left join caused by permissions filter)
* Collect permissions for current collection and dedupe access to align filter with the one used in the actual query
* Use applyFilter and an _or filter to retrieve permitted items
* Prevent certain skips in _or filters
We can only skip empty filters in `_or` if either they are not equal to the value of `cases` or if _or has exactly only exactly one empty filter
This is needed to prevent dropping joins that are required for the case/when construction. For example when having the permissions `_or: [ {}, {related_item: { id: 1} }]` all joins need to be retained
* Revert unintentional with-cache commit
* Remove check for id in children which fails on some DBs if no children are set
* Show users and roles in policy item view
* Update directus_access policy/roles + policy/users `one_deselect_action`
This ensures that the access rows are cleaned up when removing users or roles from the policy side of the relation
* Merge policy loaded from API with current edits
* Make `app_access` default to false
* Split field map into read specific and other fields
This change is necessary since process-ast is used to verify item access for actions other than `read`.
But, if a user does not have action permissions for fields used in the query filter or sort field the validation for `xByQuery` would have failed until now.
* The fields are verified separately checked against read and action specific permission.
* Updated all the tests accordingly
* Fix `hasCaseWhen` check in `getDBQuery`
Previously it was checking if `cases.length > 0` which was always true, since we always pass in at least one case (`{}`), now it checks if there are actually field nodes with a whenCase property
* Don't expose o2m fields that the user might not have access to for some items
This approach uses a flag that is introduced into the parent item db query, that uses the case/when construct to determine if a user has access to the o2m field on the specific item.
The flag is 1 if the user has access and null otherwise.
It is set in the resulting query object for all o2m fields that have a whenCase (the ones with partial access) and used when merging the nested query items into the parent items.
* Accept O2MNode as fieldNode
* Filter policies in fetchGlobalAccess by ip_access if applicable and use `withCache` util
* Filter the policies influencing the global access by ip_access filter if an ip is available
* Use `withCache` util for top level function and the two lower level functions
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
* Fix filter in roles. Again. Almost like I didn't properly test it. huh
* Add cache key stability by only picking the props that are relevant from accountability and enforcing an order in the provided options object
* Improve `fetchAllowedFields` to only return fields that are actually in the schema
* Make a local copy of `junctionFilter` in order to prevent reloads on form value changes
* Remove debug log
* Update packages/system-data/src/fields/policies.yaml
Co-authored-by: ian <licitdev@gmail.com>
* Update api/src/permissions/utils/filter-policies-by-ip.ts
Co-authored-by: ian <licitdev@gmail.com>
* Conditionally add IP to request level cache key
Add `accountability.ip` to the request level cache key if, and only if, the IP is matched by any of the `ip_access` filters of the current users policies.
This ensures that, if the request IP influences the request result, it is path of the cache key, but also not included if there are no IP filters configured for the current user.
* Update api/src/permissions/modules/fetch-policies-ip-access/fetch-policies-ip-access.ts
Co-authored-by: ian <licitdev@gmail.com>
* Make sure that fetchAllowedFields does not remove field wildcard '*'
* Temporarily disable cache key picking
* Refine cache key picking + remove `undefined` from Accountability['ip'] type
* Rename `pick` to `prepareArg`
* Define the sort field for the `directus_access` junction table
* Verify that user has access to automatically selected sort field and default to first allowed field if not
* Sort the fetched permissions to match the order of the passed in policies
* Some clean-up of TODOs and unused code
* Take care of a special case, where no fields are requested and we are still interested the correct items being returned
This surfaced when running `validateItemAccess` with an update permission that did not include the primary key field.
* 3 less
* Update api/src/database/migrations/20240328A-permissions-policies.ts
Co-authored-by: ian <licitdev@gmail.com>
* Change /permissions/me response and add corresponding types and constants
* Fix payload validation
- Field validation needs to happen for admin users as well
- Add back injection of validation rules for non-nullable fields
Tests added/adjusted accordingly
* Mark `system-permissions` interface as `system`
* Remove special handling for public policy. It's one of us now.
- Add `icon` field to policies
- Add notice to the public role
* Rename migration to most recent date
* Clear permissions cache in `clearSystemCache`
* Make `getDBQuery` not async
* Set the sort field to `null` if the user does not have any allowed fields, not even the primary key
* Handle the case where `null` is returned as item edits by the permission detail drawer and remove the existing item, if any.
* Prevent role recursion (this is a simple check right now and I would expect it to fail on nested role updates that do funky stuff)
* Add overflow to permissions table
* Ensure fields are always passed to validation-errors
When v-form is used with the `collection` prop, instead of directly
passing fields via `fields` prop, the validation-errors component
didn't receive any field information.
This is fixed, by passing down the "finalFields" from `useForm`.
This is not directly related to 'auditus', but since it seems like this will be the
only place (so far) where we want to show validation-errors on a system
collection, I'm committing here.
* Outsource 'useSave' for roles, exactly as in policies
* Clean-up policies & roles item views
- Remove leftover styles, use clearer naming 'content'
- Fix types (policies was using role type)
- Show validation errors, handle errors on save & delete
- Use loading state of v-form (to have some indicator and less layout shift)
* Mark name field in policy & role as required
That way, an indicator is shown in the form, and value is checked when
editing via drawer
* remove role filter from public registration m2o
roles dont have access fields anymore, simply allow admin roles for now
* Remove overflow again. It broke
* Add cache purging for permission related updates.
* Add `dropForeign` in migration
Fixes migration on MySQL
* Add parsed field name to field map instead of raw field name
This fixes filtering & sorting with function as keys, e.g. `year(date_updated)`
* Account for $FOLLOW field filters earlier and don't confuse them with functions (see prev commit)
* Update migration to also work with CockroachDB
Instead of altering the `policy` column on `directus_permissions` to add the NOT NULL constraint it needs to be created with NOT NULL in the first place, as this will fail in CockroachDB.
That means we need to drop the foreign key constraint for the role column in order to update to `null` `role` to the public policy ID before we copy the values into the `policy` column
* Fix typo
* Add icon to default admin policy
* Be more clear about where the public role applies
* Update api/src/permissions/lib/fetch-policies.ts
Co-authored-by: ian <licitdev@gmail.com>
* Update api/src/permissions/lib/fetch-policies.test.ts
Co-authored-by: ian <licitdev@gmail.com>
* Enable GH workflows
* Make eslint happy, cleanup and improve role sidebar in users view
* Fix wrong suggestion application and move comments in block
* Format files
* Update isFullPermission test
* Clean up policy filter logic
* Flip order in test
* Update mocking in user/flows store tests
* Update expected results of a lot of api tests that changed during development (all stay true to the original idea)
* Update parseFilter test
* Update injectCases test
* Manually set parent to `null` if a role gets deleted and remove the `SET NULL` on delete action.
The `SET NULL` action causes problems problems on OracleDB
* Fix limit check for new users w/o "status" field
status defaults to "active", thus if the field is not in payload, the
user limit check needs to be triggered
* Fixed migration "inconsistent datatypes: expected - got CLOB" error in oracle
* Update extractFieldsFromChildren test
* Fix `count(o2m)` type queries
* Update UsersService tests
- Adapt to new user integrity logic
- Add basic ItemsService tests to ensure user integrity checks take
place
* Move withAppMinimalPermissions to appropriate dir
* Fixed boolean logic error for graphql counting
* Make sure that relational function aliases are recognized as `functionField`
* Fix permission for relational functions
Before this functions that operated on a o2m field like `count(o2m)` did not respect permissions on the related collection.
Now function field nodes have a cases list as well and correctly get the cases injected for the related collection.
The permissions are then correctly injected in the query that is passed down to the relational count function helper.
* Fix mock in withAppMinimalPermissions test
* Update RolesService tests
Copied and commented out old checks from roles to policies, so we can
re-check later on
* Add preliminary changesets
* Reword changeset to "Policies"
* Update .changeset/strong-numbers-warn.md
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Policies Documentation (#22729)
Co-authored-by: Hannes Küttner <kuettner.hannes@gmail.com>
Co-authored-by: Brainslug <tim@brainslug.nl>
* Reformat docs
* SDK functions for auditus (#22795)
* Updated sdk types
* added policy commands
* prettier
* Added new and missing websocket subscription hooks
* Added missing endpoints
* Added missing graphql endpoints
* prettier
* Added changesets
* updated changesets
* Update .changeset/nine-geckos-jog.md
* Update api/src/services/graphql/index.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/rest/commands/create/policies.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/rest/commands/create/policies.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/rest/commands/read/policies.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/rest/commands/read/roles.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/rest/commands/read/policies.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/rest/commands/read/policies.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/rest/commands/read/policies.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/schema/policy.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update sdk/src/schema/policy.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
---------
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
---------
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Co-authored-by: Hannes Küttner <kuettner.hannes@gmail.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Hannes Küttner <4376726+hanneskuettner@users.noreply.github.com>
Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Kevin Lewis <kvn@lws.io>
* Change default email from in init .env to example.com
Directus's domain has a strict dmarc quarantine, so this will never work. Changing it to example should make it super obvious it's just an example.
* Add changeset
* useLogger
* Rework to useLogger and no globals
* Only export useLogger / createLogger
* Temp remove logger tests
* Refactor logger
* Refactor logger
* Refactor logger
* Refactor logger use
* Fix tests
* Fix logger usage in bootstrap
* Run formatter
* Remove logger tests
Feels drastic, but I'm about to rewrite them into @directus/logger :)
* Fix log operation test
* Content Versioning (#19463)
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
* Update clean-berries-do.md
* Prerelease mode
* v10.7.0-beta.0
* Ignore format of auto-generated pre.json file
* Update naming conventions for Content Versioning (#19678)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Content versioning tweaks (#19700)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Add additional system fields to Content Versioning & include preview in promote drawer (#19752)
* Use key instead of name for Content Versioning (#19813)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Reorder component tags
* Prompt user to keep or delete the version before promoting (#19829)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Fix multiple constraints to users system table from versions system table for MSSQL (#19912)
* fix multiple constraints from versions to users
* fix users unit test
* Add Sorting by Aggregated Queries (#19568)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
* Update API References for Content Versioning (#19911)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Add version argument in GraphQL (#19910)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Merge branch 'main' into next (#19974)
* Show installed extensions in settings pane (#19964)
* Setup boilerplate for extensions page
* Allow reading all extensions from the root endpoint
* Add basic sidebar info detail
* Render list of extensions
* Move extensions manager to folder
* Move stuff related to extensions to @directus/extensions
* Import extensions utils/types/etc from ext. package
* Resolve last imports
* Add no-extensions warning
* Start on extensions grouped
* Remove string type
* Improve naming conventions
* Couple more optimizations
* Add more structure
* Add comments
we finally understand how this works! hehe
* Remove constructor in favor of static set
* Add more comments
* Don't filter in get-extensions
TBD if this will break things horrendously
* Sprinkle on better names / comments
* Render by section, nested bundled extensions
* Fix typo
* Live-saving tip from the formatter
* Don't know where this came frmo
* Add a changeset
* 📈 Insights QoL Part 1 (#19467)
* Start adding Create Default Modal
* Add Metric List
* Number Formatter Utility
* Start on Label Formatting Options and Resizing
* Update Metric List to use New Number Formatter
* fix auto fit and styling
* fix typings for number formatter and error catching
* add conditional formatting to metric list
* Add Number Formatting to Metrics and Size Formats
* Add Option to Hide Percentage and Fix Sizing of Meter
* Add manual sizing for labels
* Add translation strings
* Add comments to insights
* Fix color errors and add icon
* update translations
* Refine Linechart
* Revert "Start adding Create Default Modal"
This reverts commit 184dd0bb73.
* Run prettier
* Remove Console Logging
* Fix Typings
* Create itchy-berries-rule.md
* Format file
* Fix Metric List for Aggre Group PR
* Remove Empty Class
* Run formatter
* Fix linter errors
* Fix import
* Update app/src/panels/label/panel-label.vue
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update app/src/panels/label/panel-label.vue
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update app/src/panels/line-chart/panel-line-chart.vue
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Remove commented css
* Remove unneeded logic
* Fix auto resizing and text alignment
* Remove Expect Error Typechecking
* Add Migration
* Fix Prettier
* Lint auto-fixes
* Fix Resizing CSS and JS
* Add Metric List Translation
* Optimize migration
* Format files
* Fix metric-list translations
* Fix type issue in metric-list/index.ts
> Default export of the module has or is using private name 'Aggregate'.ts(4082)
> Default export of the module has or is using private name 'Group'.ts(4082)
* Remove Unit Translations
* De-duplicate migration
---------
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
* SDK support for Content Versioning (#20000)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
* Add basic support for theming! (#20026)
* WIP start integrating theming
* Fix name
* Fix typo
* Move theme definition to json files
* Generate json from vite plugin
* Move default themes to root
* Render theme-provider in app
* Format variable names
* Move build script to separate npm run scrip
t
* Render correct var names in provider
* Render dark mode
* Update dependencies
* Setup styling rules for module bar
* Remove variables
* Don't rely on scoped var in editor
* Move light styles to theme
* Use theme vars in module bar
* Render theme styles in head
* Render alongside rather than wrapped
* Themable nav
* Allow using local devtools
* Do magic
* Fix auto theme fallback
* Update vue-i18n
* Use proper unicode symbol for multiplication
* Reorganize settings sidebar
* Use global translations for appearance options
* Add fields to migration
* Add theming group fields to system data
* Add strings to en-us for theming
* Add theming route that only renders theme group
* Add custom css to theming group
* Add system-theme interface
* Move default themes above custom css
* Move theme to global translations
* Use an array instead of object structure
* Add defaults for system fields
* Update migrations
* Pass theming information to provider
* Don't use default key in theme settings
* Use lodash.merge instead of defu
Better TypeScript type inference
* Nevermind the standalone app
It kinda sucks
* Only override rules
* Fetch theme overrides from user
* Use same field layout as settings
* Add theme overrides to db
* Classic 🤦🏻♂️
* Fix import
* Boilerplate overrides interface
* Update themes rules to use type def
* Boilerplate nested sections for themes
* Custom favicon (#19968)
* Add public_favicon field
* Add translation for favicon note
* Allow favicon regardless of permissions
* Return favicon as project info
* Type favicon in store
* Replace set-favicon with generate-fav util
* Render favicon in usehead
* Add changset
* Reads a little cleaner
* Semi-colons are a sign of wealth in wisdom
* Add a theme-overrides interface (#19970)
* Install typebox
* Rough in overrides interface
* Update theming settings in settings
* Upgrade dependencies
* Move theme output generation to separate composable
* Upgrade typebox
* Rename app/use-theme to use theme config
* Rework overrides interface
* Add changeset
* Allow default inheritAttrs
* Fixed handling of multiple WebSocket subscriptions on same target (#20005)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Add a cache clear method to the UtilsService (#19990)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Change csv db type to text (#19953)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update placeholder text in file-image interface (#20004)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Use current Directus version in docs (#20008)
* Use theme background instead of background-page
* Replace foreground normal with theme foreground
* Add missing translation
* Use foreground-accent and foreground-subdued from theme
* Rename --brand to --project-color
* Reuse variable color
* Replace primary/secondary/success/warning/danger
* Use theme based vars in api data
* Add header bar theming options
* Add more theming rules
* Nest icon colors
* Fix names
* Fix names in sidebar icon
* Update theming form layout
* Consolidate shades
* Consolidate primary shades
* Add primary shades
* Use shade-calculcated primary alternatives
* Use primary as mixing color
* Define warning/danger/success/secondary as shades
* Support form field label
* Add schema for interface foreground
* Allow setting input colors
* Add Google custom font loading algorithm
* Use font variables from theme
* Use unhead to load google fonts
* Install unhead to themes provider
* Use display font in title text and large dividers
* Add the dark mode default
* Run formatter
* Updating seeds is a no-no
* 😔
* Fix test
---------
Co-authored-by: Nihcep <32708027+Nihcep@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Rob Lee <rob@nodeworks.com>
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
* Fix build script on components package
* Fix RGB var usage
* Resolve Azri's notes
See https://github.com/directus/directus/pull/20026#pullrequestreview-1676876461
* Fix extensions icon
* Add ability to enable/disable extensions from App Settings (#20015)
* Add migrations for directus extensions table
* Prevent duplicate extensions from being loaded
* Add extension settings type
* Add settings getter with db sync
* Add commented out columns
For part 2!
* Load settings when loading extensions
* Normalize settings into extension info
* Use system-like output for extensions endpoint
* Render extensions overview from new meta type
* white space
* Bundle shared stuff as node exports as well
* Format file
* Fix output type of nested bundle entries
* Update package lock
* Hide uninstalled extensions
* Add disable context menu
* Hide disable controls on bundles
* Add API endpoint to update enabled state in DB
* Reload extensions on enable/disable
* Add refreshing on state change for disabled
* Remove commented out code
* Remove commented fields
* Add changeset
* Image having no empty line at the end
* Update GraphQL endpoints for extensions enable/disable (#20017)
* Update type for extensions read
* Add update extension
* Add changeset
* Update docs for updates in 19988 (#20019)
* SDK methods for extension reading/updating (#20018)
* Update SDK methods for extensions
* Add changeset
* Resolve Pascal's notes
* extracted extension api output type
* updated the update command
* Update sdk/src/types/extensions.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
---------
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Run formatter
* Add extensions to app deny list
* Fix input param name
* Fix typo in docs
* Azri is right, again!
* Remove extraneous fields
* Fix registration of operation and bundle extensions (#20030)
* Fix icon map
* Fix extension enable flag type on SQLite
* Fetch settings from itemservice
Fixes database inconsistency issues
* Only load extensions service when database is installed
---------
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
* Use theme colors in extensions settings
* 📈 Insights QoL Part 2 (#20029)
* Update Dashboard Overview Page + New Only Import Sidebar
* Update Panel Config Drawer
* Remove Old Export Function
* Add changeset
* Add Back Missing Translations
* Fix Styling
* Update Styling to use new themeing
* Fox Formatting
* Fix Last CSS Var
---------
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
* Fix auto-theme issue on public pages (#20045)
* Return default appearance from server info
* Don't default to auto
* Render light/dark class based on theme appearance
* Render browser matches dynamically
* Read default appearance on public project info
* No-mo' auto
* Fix linter error
* Use unhead to set body class attr
* Content Versioning: Small tweaks & fixes (#20020)
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
* fix input-rich-text-html body color css variable (#20049)
* Fix three small issues in `next` (#20051)
* Fix casting of json fields on sqlite
* Cast to json on user settings as well
* Prevent multiple versions of Vue/Pinia (#20066)
Co-authored-by: Brainslug <tim@brainslug.nl>
* Insights QoL - QA Fixes (#20063)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Add changeset for #20066 (#20071)
* Merge `main` into `next` (#20082)
* added save options and hide archive button for Content Versioning (#20095)
* Allow removal of version name (#20101)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Merge `main` into `next` (#20100)
* Add max length to `key` & `name` for Content Versioning (#20097)
* Make `next` ready for `main` (#20104)
* Durus: test for o2m (#19957)
* Fix casing in file names
* Refactor file structure
* Split up related field node
* formatter
* renamed fields-node.ts to fields.ts
* added o2m field in tdd test
* Split up tests
Co-authored-by: Nitwel <mail@nitwel.de>
* moved variables to test
* used random values in db response mock
* finalized actual test
* added some explanation
* encapsulated mock stream creation
* encapsulated receiving data from stream
* removed root prop in query
* Fix some spelling errors and variable names
* Remove mocked stream hotfix
* Reset mock after each test
* reduced test to a minimum
---------
Co-authored-by: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
Co-authored-by: Nitwel <mail@nitwel.de>
* fix styling for specific map buttons (#20047)
* fix styling for specific map buttons
* added myself to contributors.yml
* fix format
* fix location of code.
* removed extra space
* signed cla (#20058)
* Fix format of contributors.yml (#20068)
* Correct count param in BlobClient.download() (#20056)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* move api/errors to @directus/errors package (#20054)
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Fix http range request when transformation in use (#20060)
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Fixed SDK docblock for docs build (#20075)
* Docs: Snippet Toggler Improvements (#20077)
* Enforce Vue shorthand form for `true` attribute (#20079)
* Add homepage for quick ref in root package.json (#20083)
* Apply min-width for attached menus only (#20092)
* Apply min-width for attached menus only
* Add changeset
* Content Versioning Documentation (#20070)
* docs: add content-versioning guide
* docs: add versioning to user guide items
* updates: made updates to docs
* updates: add to headless cms guide
* fix: format
* fix: typo
* Fix link to versions ref page
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
* Use "Content Versioning" capitalized
* Addressed comments
* Format file
---------
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Kevin Lewis <kvn@lws.io>
* Allow disabling of field menu options (#20094)
* New Crowdin updates (#19816)
* New translations en-us.yaml (German)
* New translations en-us.yaml (Portuguese, Brazilian)
* New translations en-us.yaml (Persian)
* New translations en-us.yaml (Chinese Simplified)
* New translations en-us.yaml (Arabic)
* New translations en-us.yaml (Italian)
* New translations en-us.yaml (Dutch)
* New translations en-us.yaml (Vietnamese)
* New translations en-us.yaml (Spanish, Mexico)
* New translations en-us.yaml (Spanish)
* New translations en-us.yaml (Croatian)
* New translations en-us.yaml (Turkish)
* New translations en-us.yaml (Romanian)
* New translations en-us.yaml (French)
* New translations en-us.yaml (Afrikaans)
* New translations en-us.yaml (Bulgarian)
* New translations en-us.yaml (Catalan)
* New translations en-us.yaml (Czech)
* New translations en-us.yaml (Danish)
* New translations en-us.yaml (Greek)
* New translations en-us.yaml (Finnish)
* New translations en-us.yaml (Hebrew)
* New translations en-us.yaml (Hungarian)
* New translations en-us.yaml (Japanese)
* New translations en-us.yaml (Korean)
* New translations en-us.yaml (Lithuanian)
* New translations en-us.yaml (Norwegian)
* New translations en-us.yaml (Polish)
* New translations en-us.yaml (Portuguese)
* New translations en-us.yaml (Russian)
* New translations en-us.yaml (Slovak)
* New translations en-us.yaml (Slovenian)
* New translations en-us.yaml (Albanian)
* New translations en-us.yaml (Swedish)
* New translations en-us.yaml (Ukrainian)
* New translations en-us.yaml (Chinese Traditional)
* New translations en-us.yaml (Icelandic)
* New translations en-us.yaml (Indonesian)
* New translations en-us.yaml (Spanish, Chile)
* New translations en-us.yaml (Thai)
* New translations en-us.yaml (Estonian)
* New translations en-us.yaml (Hindi)
* New translations en-us.yaml (Malay)
* New translations en-us.yaml (English, Canada)
* New translations en-us.yaml (English, United Kingdom)
* New translations en-us.yaml (French, Canada)
* New translations en-us.yaml (Faroese)
* New translations en-us.yaml (Esperanto)
* New translations en-us.yaml (Breton)
* New translations en-us.yaml (Bosnian)
* New translations en-us.yaml (Serbian (Latin))
* New translations en-us.yaml (Nepali)
* New translations en-us.yaml (Sorani (Kurdish))
* New translations en-us.yaml (Spanish, Latin America)
* Update source file en-US.yaml
* Update source file en-US.yaml
* New translations en-us.yaml (Croatian)
* New translations en-us.yaml (Croatian)
* New translations en-us.yaml (Russian)
* New translations en-us.yaml (Italian)
* New translations en-us.yaml (Italian)
* New translations en-us.yaml (Italian)
* New translations en-us.yaml (Croatian)
* Update source file en-US.yaml
* Update source file en-US.yaml
* New translations en-us.yaml (German)
* New translations en-us.yaml (Greek)
* New translations en-us.yaml (Italian)
* New translations en-us.yaml (Greek)
* New translations en-us.yaml (Albanian)
* 10.6.4 (#20102)
* Exit prerelease mode
---------
Co-authored-by: Jan Arends <jan.arends@mailbox.org>
Co-authored-by: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
Co-authored-by: Nitwel <mail@nitwel.de>
Co-authored-by: Boegie19 <34578426+Boegie19@users.noreply.github.com>
Co-authored-by: Dominic <dmarx@marxulm.de>
Co-authored-by: mscbpi <ms@cbpi.ch>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Esther Agbaje <53586167+estheragbaje@users.noreply.github.com>
Co-authored-by: Kevin Lewis <kvn@lws.io>
---------
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Co-authored-by: Connor <12714889+ConnorSimply@users.noreply.github.com>
Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Nihcep <32708027+Nihcep@users.noreply.github.com>
Co-authored-by: Rob Lee <rob@nodeworks.com>
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
Co-authored-by: Jan Arends <jan.arends@mailbox.org>
Co-authored-by: Nitwel <mail@nitwel.de>
Co-authored-by: Boegie19 <34578426+Boegie19@users.noreply.github.com>
Co-authored-by: Dominic <dmarx@marxulm.de>
Co-authored-by: mscbpi <ms@cbpi.ch>
Co-authored-by: Esther Agbaje <53586167+estheragbaje@users.noreply.github.com>
Co-authored-by: Kevin Lewis <kvn@lws.io>
* Setup boilerplate for extensions page
* Allow reading all extensions from the root endpoint
* Add basic sidebar info detail
* Render list of extensions
* Move extensions manager to folder
* Move stuff related to extensions to @directus/extensions
* Import extensions utils/types/etc from ext. package
* Resolve last imports
* Temp remove settings pane
Different PR!
* Add changeset
* Run formatter
* Fix import in test
* Adding a maximum for query limit
* fixed bad env check
* using the getEnv function to make it better testable
* updated sanitize-query tests
* added tests for the validate query function
* Added DEFAULT_QUERY_LIMIT as fallback instead
* make the linter happy
* accept infinity as max_query_limit
* fixed merge conflicts
* added missing import
* moved docs PR into main repo
* added missing import
* renamed vars
* basic page size limiting
* Update app/src/layouts/cards/cards.vue
* Update app/src/layouts/map/map.vue
* Update app/src/layouts/tabular/tabular.vue
* Update app/src/layouts/tabular/tabular.vue
* Create paginate util
* extracted page size logic to composable and implemented default usage in app
* updated paginate utility
* using the new fetch-all utility
* removed limit: -1 for api calls that do not support it
* fix linter
* removed console log
* making the linter happy
* Create loud-flowers-yawn.md
* Add tests for no / unlimited limit
* Cover all cases for max limit in sanitizeQuery
* Get rid of non-null assertion
* added test for composable
* Update var names in documentation
* replace hardcoded limit default with env var
* update default page size behavior
* fixed test
* update server info api reference
* include queryLimit in graphql server info
* use configured max limit in calendar layout
* use configured max limit in kanban layout
* account for max query limit in use-revisions
---------
Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
* Step 1
* Step 2
* False sense of confidence
* Couple more before dinner
* Update schema package
* Update format-title
* Upgrade specs file
* Close
* Replace ts-node-dev with tsx, and various others
* Replace lodash with lodash-es
* Add lodash-es types
* Update knex import
* More fun is had
* FSE
* Consolidate repos
* Various tweaks and fixes
* Fix specs
* Remove dependency on knex-schema-inspector
* Fix wrong imports of inspector
* Move shared exceptions to new package
* Move constants to separate module
* Move types to new types package
* Use directus/types
* I believe this is no longer needed
* [WIP] Start moving utils to esm
* ESMify Shared
* Move shared utils to @directus/utils
* Use @directus/utils instead of @directus/shared/utils
* It runs!
* Use correct schemaoverview type
* Fix imports
* Fix the thing
* Start on new update-checker lib
* Use new update-check package
* Swap out directus/shared in app
* Pushing through the last bits now
* Dangerously make extensions SDK ESM
* Use @directus/types in tests
* Copy util function to test
* Fix linter config
* Add missing import
* Hot takes
* Fix build
* Curse these default exports
* No tests in constants
* Add tests
* Remove tests from types
* Add tests for exceptions
* Fix test
* Fix app tests
* Fix import in test
* Fix various tests
* Fix specs export
* Some more tests
* Remove broken integration tests
These were broken beyond repair.. They were also written before we really knew what we we're doing with tests, so I think it's better to say goodbye and start over with these
* Regenerate lockfile
* Fix imports from merge
* I create my own problems
* Make sharp play nice
* Add vitest config
* Install missing blackbox dep
* Consts shouldn't be in types
tsk tsk tsk tsk
* Fix type/const usage in extensions-sdk
* cursed.default
* Reduce circular deps
* Fix circular dep in items service
* vvv
* Trigger testing for all vendors
* Add workaround for rollup
* Prepend the file protocol for the ESM loader to be compatible with Windows
"WARN: Only URLs with a scheme in: file and data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'"
* Fix postgres
* Schema package updates
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
* Resolve cjs/mjs extensions
* Clean-up eslint config
* fixed extension concatination
* using string interpolation for consistency
* Revert MySQL optimisation
* Revert testing for all vendors
* Replace tsx with esbuild-kit/esm-loader
Is a bit faster and we can rely on the built-in `watch` and `inspect`
functionalities of Node.js
Note: The possibility to watch other files (.env in our case) might be
added in the future, see https://github.com/nodejs/node/issues/45467
* Use exact version for esbuild-kit/esm-loader
* Fix import
---------
Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Expose schema endpoints
* respond with 204
* fix payload for export flag
* allow export as YAML
* use SchemaService
* move getStringFromStream to utils
* clearer exceptions with logs
* check empty request body
* specs
* add bypassCache flag and remove flushCaches calls
* Identify integer typed fields in Oracle
* Fix uuid foreign keys type for Oracle
* Detect autoincrement for CockroachDB
* Bypass cache for fields and relations services
* Add same DB tests
* Test if working for all vendors
* Add schema snapshot testing into sequential flow
* Fix schema re-apply attempts when it's a different database vendor (#14816)
* prevent diffing on certain properties
* fix apply-snapshot test
* prevent updates to autoincrement fields' schema
* sanitize relations
* remove `colleciton.schema.sql` parsing in test
It is now being sanitized by `sanitizeCollection()` function in get-snapshot-diff.ts
* Change concurrency group to not cancel test running on main
* remove multipart for apply & add hash checking
* check incoming version & add force query param
* refine error message & stub for nested hash
* add `vendor` top-level property
as an additional safety net for cross db vendor applies
* sanitize generated schema snapshots
* snapshot joi validation
* diff joi validation
* minor cleanup
* extract applyDiff & use deep-diff applyChange
* use applyDiff in schema service
* Mark vendor as optional
* Update tests to apply diffs
* move force flag check into service
* Patch mssql vendor typo
* Set relation no action in cyclic relations
* Update mysql timestamp default value
* Oracle cannot define no action
* Update oracle timestamp type default values
* add hash checking for outdated diffs
* fix diff service & endpoint
* Add hashes when returning after
* Fix self referencing relations for Oracle
* Add temp fix for CURRENT_TIMESTAMP defaults in Oracle
* clean up driver and database client types
* only require diff hash if not kind N
* update hash comparison logic for create/delete
* Set no action constraint for self referencing M2M in MSSQL
* Add basic hash check tests
* omit default value when hashing auto increments
Specifically for CockroachDB with differing sequences
* add vendor check
* update specs
* Validate vendors with type definition
* Spread the vendors input array
* re-add Export component
* re-add js-yaml to root
* Propagate mutation options for schema apply
* Verify that snapshots differ and clear cache before hash tests
* Fix unit test
* Revert temp fix for CURRENT_TIMESTAMP defaults in Oracle
* Define and reuse type for export format
* Define and reuse list of database clients
* change `were` to `was`
* change `where` to `were`
* add some empty lines for readability
* tweak exception message
* fix test
* use object-hash
* use boolean to check whether file is included
* simplify request content type check
* throw error when multiple files were uploaded
* use nullish coalesce instead of short circuit
* Update api/src/services/schema.ts
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
* Remove unnecessary `Omit` on `SnapshotWithHash` type
* Revert "Remove unnecessary `Omit` on `SnapshotWithHash` type"
This reverts commit d22ac771ec.
* check empty snapshot earlier
* use allow-list logic via pick instead of omit
* Update api/src/services/schema.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Move to own /schema endpoint controller
* Fix refs to schema endpoint
* move streamToString to utils package
* move get-versioned-hash and add test
* extract kind into an enum
* Fix mysql5 timestamp value
* Fix test collection existing on rerun
* resolve TODO comment in blackbox test
* Drop deep level hashes in diff
These hashes are used only for more accurate error reporting
but are otherwise superfluous, since changes are already
detected by the top level hash.
Therefore we remove them in favor of a simpler diff format and
implementation.
* Revert schema "fix" for createItem, add comment
* Strict diff schema validation
* Revert CrDB auto-increment detection patch in 816c998
* Clear systemCache to expose newly added fields
* Use DiffKind constants
* Extract diff & snapshot validation into own tested utils
* Apply suggestions from @azrikahar
* Update knex-schema-inspector to 3.0.1
Includes the fix for CrDB auto-increment detection (knex/knex-schema-inspector#135)
* Update knex-schema-inspector in packages
* Update lock file
* add test for schema service
* add test for export service
* add relevant tests to modified util functions
* fix csv test to account for os end of line
* fix files controller test
* dedupe test data for schema service
* Align schema specs with docs
* Update api/src/controllers/schema.ts
* Revert testing for all vendors
---------
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Refactor storage logic to testable setup
* Add tests to get storage config
* Add tests for register drivers
* Tests for index
* Organize imports
* Add missing getStorage
* Setup boilerplate for cloudinary drive
* Add build script
* Add cloudinary configuration
* WIP tweaks for R&D
* Start storage abstraction v2
* Make storage manager single file
* Add test coverage
* Organize imports
* Setup local driver boilerplate
* [WIP] Start on local driver 2.0
* Add more methods
* Lunchtime
* Add put method
* Add list method
* [WIP] Try using storage in api
* Use node16 module-resolution
* Lets not mess with apply-query rn
* I love CJS. Death to CJS.
* Use dynamic imports
* Make things work
* Add path normalizer
* Add azure storage driver
* Update lock
* Start on tests
* Add getBuffer test
* Add getStat tests
* Add tests for exists
* Add tests for move
* Add tests for copy
* Add tests for put
* Add tests for delete
* Add test coverage for list
* Add removeLeading option to normalizePath
* Use removeLeading option
* Start on gcs
* Add fullpath test
* Add getStream
* Add getBuffer
* Add getStat
* Add exists
* Add move
* Add copy
* Add put
* Add delete
* Finish DriverGCS
* Cleanup tests a bit
* Start s3
* Add getStream
* Add getBuffer
* Please Wryn
* Add #exists
* Use randomize data
* No more hardcoded values 🙅♀️
* Add tests for copy
* Add tests for put
* Add put/copy/delete
* Add tests for delete
* WIP list
* Remove duplicate fullPath check
* Finish AWS tests
* Listen to wryn
* Mission critical tweak
* Add randomization, cleanup tests
* Check src vs dest full path
* Start on Cloudinary
* Add parameter signature helper
* Fix ESM building of shared
* Fix ESM building of shared
* Improve tests
* Update pnpm
* Remove old build commands
* Generated d.ts files
* Fix export naming
* Move ESM only utils to new @directus/utils
* Update lockfile
* Fix type exports
* Implement getStream
* Cleanup tests
* Simplify api
* Simplify API
* Simplify api
* Simplify API
* Add read/stat
* Cleanup / add exists
* Add move
* Add write
* Move uploadChunk to separate method
* Add test for #uploadChunk
* Add tests for write
* Add copy
* Add delete
* Add list
* Add list error handling
* Remove old drive packages
* Start updating API usage of storage
* Use Readable instead of NodeJS.ReadableStream
* Use readable instead of buffer
* Restore shared to main
* Update lockfile
* Use a streaming pipeline for sharp metadata
* Add basic e2e test for local upload and delete
* Fix integer filesize in SQLite
* fixed environment mocking in unit tests
* applied the same env mocking to other tests
* Update api/src/storage/register-drivers.ts
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Use sha256 by default
* Add base read test for /assets
* Replace exifr with exif-reader
* Fix tests for storage/index
* Install faking lib for tests
* Add test for register-drivers
* Add tests for register-locations
* Finish tests
* Organize imports
* Resolve Azris comments
* Fix outdated tests
Certainly not the cleanest, but I need to do a bigger pass on all these tests to get them up to date with the latest team requirements. Gonna do that in a separate PR..
* Test for sha256
* Attempt 1 at fixing toString errorr
I'm not seeing this issue locally, so we'll spam a couple commits here to get things going
* Use node 18 in tests?!
* Fix localhost resolution with 127.0.0.1
* Mock getEnv()
* Use @directus/tsconfig instead of duplicated conf
* Does this fix it?
* OK fun detour
* Recreate lockfile
* Update config files
* Use multipart uploads in S3
* Cleanup imports
* File Storage 2.0: Make metadata extraction backward-compatible (#16868)
* Reinstall packages using pnpm instead of manually removing them (#16871)
* Added extra environment setting for sharp processing of invalid images (#16811)
* Added extra environment setting for sharp processing of invalid images
* renamed environment var to `ASSETS_INVALID_IMAGE_SENSITIVITY_LEVEL`
* Remove unused excludes from tsconfig
* Remove copy/paste leftover
* Update packages/utils/readme.md
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
* Update packages/utils/package.json
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
* Use node16 module-resolution
* Lets not mess with apply-query rn
* I love CJS. Death to CJS.
* Use CJS require in hook import
* Fix type export in schema
* Clean up defaults usage
* Use require instead of import for migrations
* Use a vitest compatible dynamic import
* Uno mas
* Cleanup type export
* Propagate mutation options for schema apply
* Fix unit test
* Add bypassCache flag and remove flushCaches calls
* remove accountability option from getSchema
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
* build: ➕ add vitest and update test scripts
* build: 🔧 add vitest config
* build: ✅ Migrate tests to vitest
Remove jest references from test api test files and replace with vitest equivalents.
Tests: 13 tests are failing.
* build: 🚚 move vite.config.ts to api/src folder
* build: 🔥 remove unused vitest.config from api root
* build: ✅ import vitest modules for tests
* build: ✅ add type conversion for actual object
* Finish switch from Jest to Vitest in API
* Replace some leftovers
* Load "sharp" before tests
* Try with cjs
* Temporary enable verbose reporter
* Try with globalSetup
* Fix path to globalSetup
* Provide default export in globalSetup
* Final clean-up
* Remove @vitest/ui & update vitest to 0.25.0
* Add vitest c8 coverage dependency
* Update vitest to v0.25.1
* Replace unnecessary Vitest workaround
* Rework new tests
* Resolve build errors
Co-authored-by: Dorian C Brown <brown.3794@gmail.com>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
