Commit Graph

26 Commits

Author SHA1 Message Date
José Varela
999bb85539 Assets: Fix range requests (#13391)
* Return chunk even if range is greater than filesize

* Allow range.start or range.end to not be defined
Examples:
bytes=-300
bytes=300-
bytes=-300- (negative start)

* Make expression lazy instead of greedy
Fix CodeQL "Polynomial regular expression used on uncontrolled data"

* Improve checks readability

* Show proper range in case of failure

* Fix compare falsy values vs zero values

* replace regex

* Handle range validation in a single place

* Clean validation

* Use range object for exception

* Resolve range undefined check

* Prefer strict equality checks

* Cleanup

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
2022-05-19 17:01:18 +00:00
José Varela
cc076494ff Check if is UUID before check permissions (#10837)
On checking permissions it reads the value from database, so we need to verify if is UUID before this process
2022-01-04 10:04:04 -05:00
ian
851199a9fd Check if file exists in assets service (#10261)
* Check if file exists in assets service

* Remove dupliate check from assets controller

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
2021-12-03 17:29:41 +00:00
José Varela
d8e9224df6 Fix incorrect env max concurrent transforms (#8134) 2021-09-18 11:04:52 -04:00
renovate[bot]
13b92f86f3 Update dependency @types/object-hash to v2.2.1 (#8046) 2021-09-15 14:08:13 -04:00
Rijk van Zanten
d0f6cb35e3 Support dynamic variables in conditional fields (#7202)
* Move accountability type to shared

* Rely on shared for parse-filter

* Install date-fns

* Support dynamic variables in conditional fields

Closes #7157
2021-08-05 01:51:15 +02:00
Tim
2c9ff3bca6 Allow custom transformations of assets (#6593)
* Allow custom transformations of assets

This exposes one query parameter `transforms`, which is a JSON array of
shard transformation operations.

It also updates the asset presets. The UX for this still needs some work

* Rename options to arguments for presets

More explicit

* options -> arguments in setting spec

* Better errors for invalid JSON in asset presets

* Add limit to transforms query parameter

* Use flattened option for extra transforms

* Fix placeholder color of code input

* Allow "simple mode" aliases

* Add documentation

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
2021-07-21 15:57:47 -04:00
Rijk van Zanten
77e00b7db4 Don't initialize database on file require (#6003) 2021-06-02 11:41:42 -04:00
Rijk van Zanten
8d3102fbad Add max concurrency and max image transform size support (#5795)
* Add assets concurrency and max size controls

* Render no-thumbnail images nicer in app

* Document new asset environment variables

* Update package-lock
2021-05-20 18:18:10 -04:00
rijkvanzanten
801e868554 Fix remaining eslint errors
h/t @paescuj
2021-04-29 15:55:12 -04:00
Pascal Jufer
acd41eb0be Syntax fixes (#5367)
* Declare return types on functions

And a very few other type related minor fixes

* Minor syntax fixes

* Remove unnecessary escape chars in regexes
* Remove unnecessary awaits
* Replace deprecated req.connection with req.socket
* Replace deprecated upload with uploadOne
* Remove unnecessary eslint-disable-next-line comments
* Comment empty functions / catch or finally clauses
* Fix irregular whitespaces
* Add missing returns (null)
* Remove unreachable code
* A few logical fixes
* Remove / Handle non-null assertions which are certainly unnecessary (e.g. in
tests)
2021-04-29 12:11:43 -04:00
Dustin
632895eb68 Storage: S3 ACL & Content Type (#4694)
* add S3 env config for ACL. pass along file type for S3 upload

* add STORAGE_<LOCATION>_ACL to S3 docs
2021-04-07 12:15:47 -04:00
Pyll Gomez
71c8c4cc2c Assets quality parameter #4557 (#4620)
* Rotate JPG image on upload #4206

* fixes #3949 width/height generated for gif and tif

* API hooks for event added for auth.login #4079

* updated doc for api hooks for new auth.login event

* Style tweaks

* Update docs

* Tweak docs some more

* Spelling error

* Allow non-required flags and pass to hook

* SDK - Persistent login refresh fixes #4113

* Fixed #4145 SDK, Token Expired error

* Spell check

* Docs Spell check

* Docs Spell check

* Docs Spell check

* update docs for sdk-js

* To delete all expired session from db on login

* corrected the condition for the delete

* changed the from Date.now to new date .

* Move it inline

* fixes issue 4557 for asset quality for thumbnail

* asset documentation is updated

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
2021-03-22 20:08:44 -04:00
Nicola Krumschmidt
08293b8570 Update Knex to version 0.95.0 (#4374)
* Update Knex to version 0.95.0

* Fix formatting in schema dialects

* Fix Knex imports

* Update package-lock

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
2021-03-03 19:37:44 -05:00
Rijk van Zanten
1d9ffc2d7f Tweak asset metadata on upload (#4317)
* Update sharp

* Only read image metadata after upload

Preserves animated gifs and other files

Fixes #4297

* Rotate thumbnails based on exif data

Ref #4206
2021-02-26 17:18:17 -05:00
rijkvanzanten
f9685b0d4a Base content-length on stat instead of saved value 2021-02-18 13:33:03 -05:00
Rijk van Zanten
b81cfe0a49 Implement byte-range requests on /assets (#4136)
Fixes #3640
2021-02-17 17:56:44 -05:00
rijkvanzanten
e30170ab0a Fix asset permission check when you don't have settings
Fixes #887
2020-11-13 12:18:23 -05:00
rijkvanzanten
555f977af7 Fix assets not loading 2020-11-09 19:04:25 -05:00
rijkvanzanten
8cbdfb409b Use prefetched schema info 2020-11-09 17:13:48 -05:00
rijkvanzanten
31dadde0c2 Add permissions to /assets endpoint
Fixes #887
2020-11-05 18:22:15 -05:00
e01
d776bb826d Use withoutEnlargement for more consistency 2020-10-19 20:56:14 +03:00
e01
4ef8cac28e Assets improvements 2020-10-18 18:58:32 +03:00
rijkvanzanten
48fca55651 Restructure exports for services 2020-09-22 13:16:14 -04:00
rijkvanzanten
8a9e1fc2c1 Pass through non image assets in assets endpoint 2020-07-30 17:56:42 -04:00
rijkvanzanten
bde7069cce Move api into api subdirectory 2020-07-29 11:22:56 -04:00