Files
directus/api/src/app.test.ts
Rijk van Zanten ca3e7f521f Upgrade previous "Extensions" system to new "Errors" model (#18797)
* Typecheck across packages that are built with esbuild

* Boilerplate new Errors package

* No need, tsup checks with --dts

* Switch to tsup

* Setup dev script

* Add readme

* More boilerplaty things

* Finish createError function

* Install @directus/random

* Downgrade node types

* Add utility function to check if an error is a DirectusError

* Use new is-error check

* Install errors package

* Add failed validation common error

* Export common errors

* Move joi convertion to utils

* Export failed validation

* Use new failed validation error in validate-batch

* Enhance typing output of createError

* Remove outdir (handled by tsup now)

* Replace Exception with Error

* Replace exception in test

* Remove exceptions from app

* Remove exceptions from app

* Remove failed validation exception from users service

* Remove old failed validation exception from shared

* Remove exceptions package in favor of errors

* Uninstall exceptions

* Replace baseexception check

* Migrate content too large error

* Critical detail

* Replace ForbiddenException

* WIP remove exceptions

* Add ForbiddenError to errors

* HitRateLimitError

* Move validation related error/helper to new validation package

* Add index

* Add docs

* Install random

* Convert TokenExpired

* Convert user-suspended

* Convert invalid-credentials

* Move UnsupportedMediaType

* Replace wrong imports for forbidden

* Convert invalid-ip

* Move invalid provider

* Move InvalidOtp

* Convert InvalidToken

* Move MethodNotAllowed

* Convert range not satisfiable

* Move unexpect response

* Move UnprocessableContent

* Move IllegalAssetTransformation

* Move RouteNotFound

* Finalize not found

* Various db errors

* Move value too long

* Move not null

* Move record-not-unique

* Move value out of range

* Finish db errors

* Service unavailable

* GQL errors

* Update packages/validation/src/errors/failed-validation.ts

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

* Update packages/validation/src/errors/failed-validation.ts

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

* InvalidQuery

* Add test for invalid query message constructor

* Invalid Payload

* Finalize exceptions move

* Improve type of isDirectusError

* Various fixes

* Fix build in api

* Update websocket exceptions use

* Allow optional reason for invalid config

* Update errors usage in utils

* Remove unused package from errors

* Update lockfile

* Update api/src/auth/drivers/ldap.ts

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

* Update packages/validation/src/utils/joi-to-error-extensions.ts

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

* Put error codes in shared enum

* Replace instanceof checks in api

* Fix tests I think

* Tweak override names

* Fix linter warnings

* Set snapshots

* Start fixing BB tests

* Fix blackbox tests

* Add changeset

* Update changeset

* Update extension docs to use new createError abstraction

* 🙄

* Fix graphql validation error name

* 🥳

* use ErrorCode.Forbidden

* fix blackbox auth login test

* Add license files

* Rename preMutationException to preMutationError

* Remove unused ms dep & sort package.json

* Remove periods from error messages for consistency

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

* Add optional code check

* Use updated error code checker

* Rename InvalidConfigError to InvalidProviderConfigError

---------

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: ian <licitdev@gmail.com>
2023-06-27 17:22:26 -04:00

210 lines
5.5 KiB
TypeScript

import { Router } from 'express';
import request from 'supertest';
import { describe, expect, test, vi } from 'vitest';
import createApp from './app.js';
vi.mock('./database', () => ({
default: vi.fn(),
getDatabaseClient: vi.fn().mockReturnValue('postgres'),
isInstalled: vi.fn(),
validateDatabaseConnection: vi.fn(),
validateDatabaseExtensions: vi.fn(),
validateMigrations: vi.fn(),
}));
vi.mock('./env', async () => {
const actual = (await vi.importActual('./env')) as { default: Record<string, any> };
const MOCK_ENV = {
...actual.default,
KEY: 'xxxxxxx-xxxxxx-xxxxxxxx-xxxxxxxxxx',
SECRET: 'abcdef',
SERVE_APP: true,
PUBLIC_URL: 'http://localhost:8055/directus',
TELEMETRY: false,
LOG_STYLE: 'raw',
};
return {
default: MOCK_ENV,
getEnv: () => MOCK_ENV,
};
});
const mockGetEndpointRouter = vi.fn().mockReturnValue(Router());
const mockGetEmbeds = vi.fn().mockReturnValue({ head: '', body: '' });
vi.mock('./extensions', () => ({
getExtensionManager: vi.fn().mockImplementation(() => {
return {
initialize: vi.fn(),
getEndpointRouter: mockGetEndpointRouter,
getEmbeds: mockGetEmbeds,
};
}),
}));
vi.mock('./flows', () => ({
getFlowManager: vi.fn().mockImplementation(() => {
return {
initialize: vi.fn(),
};
}),
}));
vi.mock('./middleware/check-ip', () => ({
checkIP: Router(),
}));
vi.mock('./middleware/schema', () => ({
default: Router(),
}));
vi.mock('./middleware/get-permissions', () => ({
default: Router(),
}));
vi.mock('./auth', () => ({
registerAuthProviders: vi.fn(),
}));
vi.mock('./webhooks', () => ({
init: vi.fn(),
}));
describe('createApp', async () => {
describe('Content Security Policy', () => {
test('Should set content-security-policy header by default', async () => {
const app = await createApp();
const response = await request(app).get('/');
expect(response.headers).toHaveProperty('content-security-policy');
});
});
describe('Root Redirect', () => {
test('Should redirect root path by default', async () => {
const app = await createApp();
const response = await request(app).get('/');
expect(response.status).toEqual(302);
});
});
describe('robots.txt file', () => {
test('Should respond with default robots.txt content', async () => {
const app = await createApp();
const response = await request(app).get('/robots.txt');
expect(response.text).toEqual('User-agent: *\nDisallow: /');
});
});
describe('Admin App', () => {
test('Should set <base /> tag href to public url with admin relative path', async () => {
const app = await createApp();
const response = await request(app).get('/admin');
expect(response.text).toEqual(expect.stringContaining(`<base href="/directus/admin/" />`));
});
test('Should remove <embed-head /> and <embed-body /> tags when there are no custom embeds', async () => {
mockGetEmbeds.mockReturnValueOnce({ head: '', body: '' });
const app = await createApp();
const response = await request(app).get('/admin');
expect(response.text).not.toEqual(expect.stringContaining(`<embed-head />`));
expect(response.text).not.toEqual(expect.stringContaining(`<embed-body />`));
});
test('Should replace <embed-head /> tag with custom embed head', async () => {
const mockEmbedHead = '<!-- Test Embed Head -->';
mockGetEmbeds.mockReturnValueOnce({ head: mockEmbedHead, body: '' });
const app = await createApp();
const response = await request(app).get('/admin');
expect(response.text).toEqual(expect.stringContaining(mockEmbedHead));
});
test('Should replace <embed-body /> tag with custom embed body', async () => {
const mockEmbedBody = '<!-- Test Embed Body -->';
mockGetEmbeds.mockReturnValueOnce({ head: '', body: mockEmbedBody });
const app = await createApp();
const response = await request(app).get('/admin');
expect(response.text).toEqual(expect.stringContaining(mockEmbedBody));
});
});
describe('Server ping endpoint', () => {
test('Should respond with pong', async () => {
const app = await createApp();
const response = await request(app).get('/server/ping');
expect(response.text).toEqual('pong');
});
});
describe('Custom Endpoints', () => {
test('Should not contain route for custom endpoint', async () => {
const testRoute = '/custom-endpoint-to-test';
const app = await createApp();
const response = await request(app).get(testRoute);
expect(response.body).toEqual({
errors: [
{
extensions: {
code: 'ROUTE_NOT_FOUND',
path: '/custom-endpoint-to-test',
},
message: `Route ${testRoute} doesn't exist.`,
},
],
});
});
test('Should contain route for custom endpoint', async () => {
const testRoute = '/custom-endpoint-to-test';
const testResponse = { key: 'value' };
const mockRouter = Router();
mockRouter.use(testRoute, (_, res) => {
res.json(testResponse);
});
mockGetEndpointRouter.mockReturnValueOnce(mockRouter);
const app = await createApp();
const response = await request(app).get(testRoute);
expect(response.body).toEqual(testResponse);
});
});
describe('Not Found Handler', () => {
test('Should return ROUTE_NOT_FOUND error when a route does not exist', async () => {
const testRoute = '/this-route-does-not-exist';
const app = await createApp();
const response = await request(app).get(testRoute);
expect(response.body).toEqual({
errors: [
{
extensions: {
code: 'ROUTE_NOT_FOUND',
path: '/this-route-does-not-exist',
},
message: `Route ${testRoute} doesn't exist.`,
},
],
});
});
});
});