Files
directus/tests/api/schema/datetime-changed-node-tz-asia.test.ts
ian 68066eccb7 Remove UTC conversion from date, time and datetime fields (#10956)
* Remove UTC conversion from date, time and datetime fields

* Fix mysql / maria timestamps when not in UTC timezone

* Add sequential tests with node timezone change

* Increase connection attempt check

* Add error catching in tests flow setup

* Check for server connectivity

* Fix promises

* Fix timestamp inconsistencies

* Revert to previously used parseISO

* Ensure database and directus connection

* Add another timezone to test positive and negative GMT

* Set local server hostname to localhost

* Add tests for SQLite

* Use notNullable primary key

* Revert connection testing sleep duration

* Fix nested transactions on SQLite

* Increase MSSQL request timeout

* Add type override flag for SQLite

* Remove commented code

* Add type override flags for Oracle

* Updated test file path

* Increase test servers launch timeout

* Increase test servers launch timeout

* Update format of tests

* Fix typo

* Increase test timeout for CockroachDB

* Add type overrides when creating fields through collections service

* Remove time field type conversion for Oracle

* Update collections list in test

* Remove check for time field in Oracle

* Add missing continue...

* Remove database override

* Add note for SQLite

* Rename flags and extract shared util

* Abstract remaining DB specific checks

* Revert flags renaming except renaming of test files

* Use date helper to add field flag

* Move field date typecasting upstream

* Use timestamp helper for date-created and date-updated

* Fix tests

* Remove unused vars

* Add tests for date-created

* Increase connection attempt count

* Fix test for mariadb

* Increase allowable difference to account for delays

* Add tests for date-updated

* Fix tests again for mariadb

* Add date helpers post merge

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
2022-04-06 16:15:22 -04:00

354 lines
12 KiB
TypeScript

import config, { getUrl } from '../../config';
import vendors from '../../get-dbs-to-test';
import request from 'supertest';
import knex, { Knex } from 'knex';
import { find, cloneDeep } from 'lodash';
import { spawn, ChildProcess } from 'child_process';
import { awaitDirectusConnection } from '../../setup/utils/await-connection';
import { validateDateDifference } from '../utils/validate-date-difference';
type SchemaDateTypesObject = {
id: number;
date: string;
time?: string;
datetime: string;
timestamp: string;
};
type SchemaDateTypesResponse = SchemaDateTypesObject & {
date_created: string;
date_updated: string;
};
describe('schema', () => {
const databases = new Map<string, Knex>();
const tzDirectus = {} as { [vendor: string]: ChildProcess };
const currentTzOffset = new Date().getTimezoneOffset();
const isWindows = ['win32', 'win64'].includes(process.platform);
const newTzOffset = currentTzOffset !== -540 ? -540 : -240;
// Different timezone format for Windows
const newTz = isWindows ? String(newTzOffset * 60) : newTzOffset === -540 ? 'Asia/Seoul' : 'Asia/Dubai';
const sampleDates: SchemaDateTypesObject[] = [];
for (let i = 0; i < 24; i++) {
const hour = i < 10 ? '0' + i : String(i);
sampleDates.push(
{
id: 1 + i * 3,
date: `2022-01-05`,
time: `${hour}:11:11`,
datetime: `2022-01-05T${hour}:11:11`,
timestamp: `2022-01-05T${hour}:11:11-01:00`,
},
{
id: 2 + i * 3,
date: `2022-01-10`,
time: `${hour}:22:22`,
datetime: `2022-01-10T${hour}:22:22`,
timestamp: `2022-01-10T${hour}:22:22Z`,
},
{
id: 3 + i * 3,
date: `2022-01-15`,
time: `${hour}:33:33`,
datetime: `2022-01-15T${hour}:33:33`,
timestamp: `2022-01-15T${hour}:33:33+02:00`,
}
);
}
const sampleDatesAmerica = cloneDeep(sampleDates);
for (const date of sampleDatesAmerica) {
date.id += sampleDatesAmerica.length;
}
const sampleDatesAsia = cloneDeep(sampleDatesAmerica);
for (const date of sampleDatesAsia) {
date.id += sampleDatesAsia.length;
}
beforeAll(async () => {
const promises = [];
for (const vendor of vendors) {
const newServerPort = Number(config.envs[vendor]!.PORT) + 100;
databases.set(vendor, knex(config.knexConfig[vendor]!));
config.envs[vendor]!.TZ = newTz;
config.envs[vendor]!.PORT = String(newServerPort);
const server = spawn('node', ['api/cli', 'start'], { env: config.envs[vendor] });
tzDirectus[vendor] = server;
let serverOutput = '';
server.stdout.on('data', (data) => (serverOutput += data.toString()));
server.on('exit', (code) => {
if (code !== null) throw new Error(`Directus-${vendor} server failed: \n ${serverOutput}`);
});
promises.push(awaitDirectusConnection(newServerPort));
}
// Give the server some time to start
await Promise.all(promises);
}, 180000);
afterAll(async () => {
for (const [vendor, connection] of databases) {
tzDirectus[vendor]!.kill();
config.envs[vendor]!.PORT = String(Number(config.envs[vendor]!.PORT) - 100);
delete config.envs[vendor]!.TZ;
await connection.destroy();
}
});
describe('Date Types (Changed Node Timezone Asia)', () => {
describe('returns existing datetime data correctly', () => {
it.each(vendors)('%s', async (vendor) => {
const currentTimestamp = new Date();
const response = await request(getUrl(vendor))
.get(`/items/schema_date_types?fields=*&limit=${sampleDates.length}`)
.set('Authorization', 'Bearer AdminToken')
.expect('Content-Type', /application\/json/)
.expect(200);
expect(response.body.data.length).toBe(sampleDates.length);
for (let index = 0; index < sampleDates.length; index++) {
const responseObj = find(response.body.data, (o) => {
return o.id === sampleDates[index]!.id;
}) as SchemaDateTypesResponse;
if (vendor === 'sqlite3') {
// Dates are saved in milliseconds at 00:00:00
const newDateString = new Date(
new Date(sampleDates[index]!.date + 'T00:00:00+00:00').valueOf() - newTzOffset * 60 * 1000
).toISOString();
const newDateTimeString = new Date(
new Date(sampleDates[index]!.datetime + '+00:00').valueOf() - newTzOffset * 60 * 1000
).toISOString();
expect(responseObj.date).toBe(newDateString.substring(0, 10));
expect(responseObj.time).toBe(sampleDates[index]!.time);
expect(responseObj.datetime).toBe(newDateTimeString.substring(0, 19));
expect(responseObj.timestamp.substring(0, 19)).toBe(
new Date(sampleDates[index]!.timestamp).toISOString().substring(0, 19)
);
const dateCreated = new Date(responseObj.date_created);
expect(dateCreated.toISOString()).toBe(
validateDateDifference(currentTimestamp, dateCreated, 400000).toISOString()
);
continue;
} else if (vendor === 'oracle') {
expect(responseObj.date).toBe(sampleDates[index]!.date);
expect(responseObj.datetime).toBe(sampleDates[index]!.datetime);
expect(responseObj.timestamp.substring(0, 19)).toBe(
new Date(sampleDates[index]!.timestamp).toISOString().substring(0, 19)
);
const dateCreated = new Date(responseObj.date_created);
expect(dateCreated.toISOString()).toBe(
validateDateDifference(currentTimestamp, dateCreated, 400000).toISOString()
);
continue;
}
expect(responseObj.date).toBe(sampleDates[index]!.date);
expect(responseObj.time).toBe(sampleDates[index]!.time);
expect(responseObj.datetime).toBe(sampleDates[index]!.datetime);
expect(responseObj.timestamp.substring(0, 19)).toBe(
new Date(sampleDates[index]!.timestamp).toISOString().substring(0, 19)
);
const dateCreated = new Date(responseObj.date_created);
expect(dateCreated.toISOString()).toBe(
validateDateDifference(currentTimestamp, dateCreated, 200000).toISOString()
);
}
const americanTzOffset = currentTzOffset !== 180 ? 180 : 360;
const response2 = await request(getUrl(vendor))
.get(`/items/schema_date_types?fields=*&offset=${sampleDatesAmerica.length}`)
.set('Authorization', 'Bearer AdminToken')
.expect('Content-Type', /application\/json/)
.expect(200);
expect(response2.body.data.length).toBe(sampleDatesAmerica.length);
for (let index = 0; index < sampleDatesAmerica.length; index++) {
const responseObj = find(response2.body.data, (o) => {
return o.id === sampleDatesAmerica[index]!.id;
}) as SchemaDateTypesResponse;
if (vendor === 'sqlite3') {
// Dates are saved in milliseconds at 00:00:00
const newDateString = new Date(
new Date(sampleDates[index]!.date + 'T00:00:00+00:00').valueOf() -
(newTzOffset - americanTzOffset) * 60 * 1000
).toISOString();
const newDateTimeString = new Date(
new Date(sampleDates[index]!.datetime + '+00:00').valueOf() - (newTzOffset - americanTzOffset) * 60 * 1000
).toISOString();
expect(responseObj.date).toBe(newDateString.substring(0, 10));
expect(responseObj.time).toBe(sampleDates[index]!.time);
expect(responseObj.datetime).toBe(newDateTimeString.substring(0, 19));
expect(responseObj.timestamp.substring(0, 19)).toBe(
new Date(sampleDatesAmerica[index]!.timestamp).toISOString().substring(0, 19)
);
const dateCreated = new Date(responseObj.date_created);
expect(dateCreated.toISOString()).toBe(
validateDateDifference(currentTimestamp, dateCreated, 200000).toISOString()
);
continue;
} else if (vendor === 'oracle') {
expect(responseObj.date).toBe(sampleDatesAmerica[index]!.date);
expect(responseObj.datetime).toBe(sampleDatesAmerica[index]!.datetime);
expect(responseObj.timestamp.substring(0, 19)).toBe(
new Date(sampleDatesAmerica[index]!.timestamp).toISOString().substring(0, 19)
);
const dateCreated = new Date(responseObj.date_created);
expect(dateCreated.toISOString()).toBe(
validateDateDifference(currentTimestamp, dateCreated, 200000).toISOString()
);
continue;
}
expect(responseObj.date).toBe(sampleDatesAmerica[index]!.date);
expect(responseObj.time).toBe(sampleDatesAmerica[index]!.time);
expect(responseObj.datetime).toBe(sampleDatesAmerica[index]!.datetime);
expect(responseObj.timestamp.substring(0, 19)).toBe(
new Date(sampleDatesAmerica[index]!.timestamp).toISOString().substring(0, 19)
);
const dateCreated = new Date(responseObj.date_created);
expect(dateCreated.toISOString()).toBe(
validateDateDifference(currentTimestamp, dateCreated, 200000).toISOString()
);
}
});
});
describe('stores the correct datetime data', () => {
it.each(vendors)(
'%s',
async (vendor) => {
const dates = cloneDeep(sampleDatesAsia);
if (vendor === 'oracle') {
for (const date of dates) {
delete date.time;
}
}
const insertionStartTimestamp = new Date();
await request(getUrl(vendor))
.post(`/items/schema_date_types`)
.send(dates)
.set('Authorization', 'Bearer AdminToken')
.expect('Content-Type', /application\/json/)
.expect(200);
const insertionEndTimestamp = new Date();
const response = await request(getUrl(vendor))
.get(`/items/schema_date_types?fields=*&offset=${sampleDates.length + sampleDatesAmerica.length}`)
.set('Authorization', 'Bearer AdminToken')
.expect('Content-Type', /application\/json/)
.expect(200);
expect(response.body.data.length).toBe(sampleDatesAsia.length);
for (let index = 0; index < sampleDatesAsia.length; index++) {
const responseObj = find(response.body.data, (o) => {
return o.id === sampleDatesAsia[index]!.id;
}) as SchemaDateTypesResponse;
if (vendor === 'oracle') {
expect(responseObj.date).toBe(sampleDatesAsia[index]!.date);
expect(responseObj.datetime).toBe(sampleDatesAsia[index]!.datetime);
expect(responseObj.timestamp.substring(0, 19)).toBe(
new Date(sampleDatesAsia[index]!.timestamp).toISOString().substring(0, 19)
);
const dateCreated = new Date(responseObj.date_created);
expect(dateCreated.toISOString()).toBe(
validateDateDifference(
insertionStartTimestamp,
dateCreated,
insertionEndTimestamp.getTime() - insertionStartTimestamp.getTime()
).toISOString()
);
expect(responseObj.date_updated).toBeNull();
continue;
}
expect(responseObj.date).toBe(sampleDatesAsia[index]!.date);
expect(responseObj.time).toBe(sampleDatesAsia[index]!.time);
expect(responseObj.datetime).toBe(sampleDatesAsia[index]!.datetime);
expect(responseObj.timestamp.substring(0, 19)).toBe(
new Date(sampleDatesAsia[index]!.timestamp).toISOString().substring(0, 19)
);
const dateCreated = new Date(responseObj.date_created);
expect(dateCreated.toISOString()).toBe(
validateDateDifference(
insertionStartTimestamp,
dateCreated,
insertionEndTimestamp.getTime() - insertionStartTimestamp.getTime() + 1000
).toISOString()
);
expect(responseObj.date_updated).toBeNull();
}
},
10000
);
});
describe('stores the correct timestamp when updated', () => {
it.each(vendors)('%s', async (vendor) => {
const payload = {
date: sampleDatesAsia[0]!.date,
};
const updateStartTimestamp = new Date();
await request(getUrl(vendor))
.patch(`/items/schema_date_types/${sampleDatesAsia[0]!.id}`)
.send(payload)
.set('Authorization', 'Bearer AdminToken')
.expect('Content-Type', /application\/json/)
.expect(200);
const updateEndTimestamp = new Date();
const response = await request(getUrl(vendor))
.get(`/items/schema_date_types/${sampleDatesAsia[0]!.id}?fields=*`)
.set('Authorization', 'Bearer AdminToken')
.expect('Content-Type', /application\/json/)
.expect(200);
const responseObj = response.body.data as SchemaDateTypesResponse;
expect(responseObj.date).toBe(sampleDatesAsia[0]!.date);
expect(responseObj.date_created).not.toBeNull();
expect(responseObj.date_updated).not.toBeNull();
const dateCreated = new Date(responseObj.date_created);
const dateUpdated = new Date(responseObj.date_updated);
expect(dateUpdated.toISOString()).not.toBe(dateCreated.toISOString());
expect(dateUpdated.toISOString()).toBe(
validateDateDifference(
updateStartTimestamp,
dateUpdated,
updateEndTimestamp.getTime() - updateStartTimestamp.getTime() + 1000
).toISOString()
);
});
});
});
});