Files
directus/api/src/logger.test.ts
Rijk van Zanten 2983e61870 The Great TypeScript Modernization Program Season 3 Episode 6: The Big One (#18014)
* Step 1

* Step 2

* False sense of confidence

* Couple more before dinner

* Update schema package

* Update format-title

* Upgrade specs file

* Close

* Replace ts-node-dev with tsx, and various others

* Replace lodash with lodash-es

* Add lodash-es types

* Update knex import

* More fun is had

* FSE

* Consolidate repos

* Various tweaks and fixes

* Fix specs

* Remove dependency on knex-schema-inspector

* Fix wrong imports of inspector

* Move shared exceptions to new package

* Move constants to separate module

* Move types to new types package

* Use directus/types

* I believe this is no longer needed

* [WIP] Start moving utils to esm

* ESMify Shared

* Move shared utils to  @directus/utils

* Use @directus/utils instead of @directus/shared/utils

* It runs!

* Use correct schemaoverview type

* Fix imports

* Fix the thing

* Start on new update-checker lib

* Use new update-check package

* Swap out directus/shared in app

* Pushing through the last bits now

* Dangerously make extensions SDK ESM

* Use @directus/types in tests

* Copy util function to test

* Fix linter config

* Add missing import

* Hot takes

* Fix build

* Curse these default exports

* No tests in constants

* Add tests

* Remove tests from types

* Add tests for exceptions

* Fix test

* Fix app tests

* Fix import in test

* Fix various tests

* Fix specs export

* Some more tests

* Remove broken integration tests

These were broken beyond repair.. They were also written before we really knew what we we're doing with tests, so I think it's better to say goodbye and start over with these

* Regenerate lockfile

* Fix imports from merge

* I create my own problems

* Make sharp play nice

* Add vitest config

* Install missing blackbox dep

* Consts shouldn't be in types

tsk tsk tsk tsk

* Fix type/const usage in extensions-sdk

* cursed.default

* Reduce circular deps

* Fix circular dep in items service

* vvv

* Trigger testing for all vendors

* Add workaround for rollup

* Prepend the file protocol for the ESM loader to be compatible with Windows
"WARN: Only URLs with a scheme in: file and data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'"

* Fix postgres

* Schema package updates

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

* Resolve cjs/mjs extensions

* Clean-up eslint config

* fixed extension concatination

* using string interpolation for consistency

* Revert MySQL optimisation

* Revert testing for all vendors

* Replace tsx with esbuild-kit/esm-loader

Is a bit faster and we can rely on the built-in `watch` and `inspect`
functionalities of Node.js

Note: The possibility to watch other files (.env in our case) might be
added in the future, see https://github.com/nodejs/node/issues/45467

* Use exact version for esbuild-kit/esm-loader

* Fix import

---------

Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
2023-04-04 17:41:56 -04:00

141 lines
3.5 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
const REFRESH_TOKEN_COOKIE_NAME = 'directus_refresh_token';
vi.mock('./env', async () => {
const MOCK_ENV = {
AUTH_PROVIDERS: 'ranger,monospace',
AUTH_RANGER_DRIVER: 'oauth2',
AUTH_MONOSPACE_DRIVER: 'openid',
REFRESH_TOKEN_COOKIE_NAME,
LOG_LEVEL: 'info',
LOG_STYLE: 'raw',
};
return {
default: MOCK_ENV,
getEnv: () => MOCK_ENV,
};
});
import { Writable } from 'node:stream';
import { pino } from 'pino';
import { REDACT_TEXT } from './constants.js';
import { httpLoggerOptions } from './logger.js';
const logOutput = vi.fn();
let stream: Writable;
beforeEach(() => {
stream = new Writable({
write(chunk) {
logOutput(JSON.parse(chunk.toString()));
},
});
});
afterEach(() => {
vi.clearAllMocks();
});
describe('req.headers.authorization', () => {
test('Should redact bearer token in Authorization header', () => {
const instance = pino(httpLoggerOptions, stream);
instance.info({
req: {
headers: {
authorization: `Bearer test-access-token-value`,
},
},
});
expect(logOutput.mock.calls[0][0]).toMatchObject({
req: {
headers: {
authorization: REDACT_TEXT,
},
},
});
});
});
describe('req.headers.cookie', () => {
test('Should redact refresh token when there is only one entry', () => {
const instance = pino(httpLoggerOptions, stream);
instance.info({
req: {
headers: {
cookie: `${REFRESH_TOKEN_COOKIE_NAME}=test-refresh-token-value`,
},
},
});
expect(logOutput.mock.calls[0][0]).toMatchObject({
req: {
headers: {
cookie: REDACT_TEXT,
},
},
});
});
test('Should redact refresh token with multiple entries', () => {
const instance = pino(httpLoggerOptions, stream);
instance.info({
req: {
headers: {
cookie: `custom_test_cookie=custom_test_value; access_token=test-access-token-value; oauth2.ranger=test-oauth2-value; openid.monospace=test-openid-value; ${REFRESH_TOKEN_COOKIE_NAME}=test-refresh-token-value`,
},
},
});
expect(logOutput.mock.calls[0][0]).toMatchObject({
req: {
headers: {
cookie: REDACT_TEXT,
},
},
});
});
});
describe('res.headers', () => {
test('Should redact refresh token when there is only one entry', () => {
const instance = pino(httpLoggerOptions, stream);
instance.info({
res: {
headers: {
'set-cookie': `${REFRESH_TOKEN_COOKIE_NAME}=test-refresh-token-value; Max-Age=604800; Path=/; Expires=Tue, 14 Feb 2023 12:00:00 GMT; HttpOnly; SameSite=Lax`,
},
},
});
expect(logOutput.mock.calls[0][0]).toMatchObject({
res: {
headers: {
'set-cookie': REDACT_TEXT,
},
},
});
});
test('Should redact refresh token with multiple entries', () => {
const instance = pino(httpLoggerOptions, stream);
instance.info({
res: {
headers: {
'set-cookie': [
`access_token=test-access-token-value; Max-Age=604800; Path=/; Expires=Tue, 14 Feb 2023 12:00:00 GMT; HttpOnly; SameSite=Lax`,
`oauth2.ranger=test-oauth2-value; Max-Age=604800; Path=/; Expires=Tue, 14 Feb 2023 12:00:00 GMT; HttpOnly; SameSite=Lax`,
`openid.monospace=test-openid-value; Max-Age=604800; Path=/; Expires=Tue, 14 Feb 2023 12:00:00 GMT; HttpOnly; SameSite=Lax`,
`${REFRESH_TOKEN_COOKIE_NAME}=test-refresh-token-value; Max-Age=604800; Path=/; Expires=Tue, 14 Feb 2023 12:00:00 GMT; HttpOnly; SameSite=Lax`,
],
},
},
});
expect(logOutput.mock.calls[0][0]).toMatchObject({
res: {
headers: {
'set-cookie': REDACT_TEXT,
},
},
});
});
});