Files
directus/api/src/utils/should-skip-cache.test.ts
Rijk van Zanten 2983e61870 The Great TypeScript Modernization Program Season 3 Episode 6: The Big One (#18014)
* Step 1

* Step 2

* False sense of confidence

* Couple more before dinner

* Update schema package

* Update format-title

* Upgrade specs file

* Close

* Replace ts-node-dev with tsx, and various others

* Replace lodash with lodash-es

* Add lodash-es types

* Update knex import

* More fun is had

* FSE

* Consolidate repos

* Various tweaks and fixes

* Fix specs

* Remove dependency on knex-schema-inspector

* Fix wrong imports of inspector

* Move shared exceptions to new package

* Move constants to separate module

* Move types to new types package

* Use directus/types

* I believe this is no longer needed

* [WIP] Start moving utils to esm

* ESMify Shared

* Move shared utils to  @directus/utils

* Use @directus/utils instead of @directus/shared/utils

* It runs!

* Use correct schemaoverview type

* Fix imports

* Fix the thing

* Start on new update-checker lib

* Use new update-check package

* Swap out directus/shared in app

* Pushing through the last bits now

* Dangerously make extensions SDK ESM

* Use @directus/types in tests

* Copy util function to test

* Fix linter config

* Add missing import

* Hot takes

* Fix build

* Curse these default exports

* No tests in constants

* Add tests

* Remove tests from types

* Add tests for exceptions

* Fix test

* Fix app tests

* Fix import in test

* Fix various tests

* Fix specs export

* Some more tests

* Remove broken integration tests

These were broken beyond repair.. They were also written before we really knew what we we're doing with tests, so I think it's better to say goodbye and start over with these

* Regenerate lockfile

* Fix imports from merge

* I create my own problems

* Make sharp play nice

* Add vitest config

* Install missing blackbox dep

* Consts shouldn't be in types

tsk tsk tsk tsk

* Fix type/const usage in extensions-sdk

* cursed.default

* Reduce circular deps

* Fix circular dep in items service

* vvv

* Trigger testing for all vendors

* Add workaround for rollup

* Prepend the file protocol for the ESM loader to be compatible with Windows
"WARN: Only URLs with a scheme in: file and data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'"

* Fix postgres

* Schema package updates

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

* Resolve cjs/mjs extensions

* Clean-up eslint config

* fixed extension concatination

* using string interpolation for consistency

* Revert MySQL optimisation

* Revert testing for all vendors

* Replace tsx with esbuild-kit/esm-loader

Is a bit faster and we can rely on the built-in `watch` and `inspect`
functionalities of Node.js

Note: The possibility to watch other files (.env in our case) might be
added in the future, see https://github.com/nodejs/node/issues/45467

* Use exact version for esbuild-kit/esm-loader

* Fix import

---------

Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
2023-04-04 17:41:56 -04:00

71 lines
1.9 KiB
TypeScript

import type { Request } from 'express';
import { expect, test, vi } from 'vitest';
import { getEnv } from '../env.js';
import { shouldSkipCache } from './should-skip-cache.js';
vi.mock('../env');
test.each([
{ scenario: 'not relative', publicURL: 'http://admin.example.com', refererHost: '' },
{ scenario: 'relative', publicURL: '/', refererHost: 'http://ignore.domain' },
{ scenario: 'relative with subdirectory', publicURL: '/test/subfolder', refererHost: 'http://ignore.domain' },
])(
'should always skip cache for requests coming from data studio when public URL is $scenario',
({ publicURL, refererHost }) => {
vi.mocked(getEnv).mockReturnValue({ PUBLIC_URL: publicURL, CACHE_SKIP_ALLOWED: false });
const req = {
get: vi.fn((str) => {
switch (str) {
case 'Referer':
return `${refererHost}${publicURL}/admin/settings/data-model`;
default:
return undefined;
}
}),
} as unknown as Request;
expect(shouldSkipCache(req)).toBe(true);
}
);
test('should not skip cache for requests coming outside of data studio', () => {
vi.mocked(getEnv).mockReturnValue({ PUBLIC_URL: 'http://admin.example.com', CACHE_SKIP_ALLOWED: false });
const req = {
get: vi.fn((str) => {
switch (str) {
case 'Referer':
return `http://elsewhere.example.com/admin/settings/data-model`;
default:
return undefined;
}
}),
} as unknown as Request;
expect(shouldSkipCache(req)).toBe(false);
});
test.each([
{ scenario: 'accept', value: true },
{ scenario: 'ignore', value: false },
])(
'should $scenario Cache-Control request header containing "no-store" when CACHE_SKIP_ALLOWED is $value',
({ value }) => {
vi.mocked(getEnv).mockReturnValue({ PUBLIC_URL: '/', CACHE_SKIP_ALLOWED: value });
const req = {
get: vi.fn((str) => {
switch (str) {
case 'cache-control':
return 'no-store';
default:
return undefined;
}
}),
} as unknown as Request;
expect(shouldSkipCache(req)).toBe(value);
}
);