mirror of
https://github.com/directus/directus.git
synced 2026-01-26 03:38:09 -05:00
* Process relational collection's permissions in functions * Fix deep usage of functions in GraphQL * Add unit test for updated SQL query with permissions Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
970 lines
29 KiB
TypeScript
970 lines
29 KiB
TypeScript
import { Query } from '@directus/shared/types';
|
|
import knex, { Knex } from 'knex';
|
|
import { getTracker, MockClient, Tracker } from 'knex-mock-client';
|
|
import { ItemsService } from '../../src/services';
|
|
import { sqlFieldFormatter, sqlFieldList } from '../__test-utils__/items-utils';
|
|
import { systemSchema, userSchema } from '../__test-utils__/schemas';
|
|
import { cloneDeep } from 'lodash';
|
|
|
|
jest.mock('../../src/database/index', () => {
|
|
return { getDatabaseClient: jest.fn().mockReturnValue('postgres') };
|
|
});
|
|
jest.requireMock('../../src/database/index');
|
|
|
|
describe('Integration Tests', () => {
|
|
let db: jest.Mocked<Knex>;
|
|
let tracker: Tracker;
|
|
|
|
const schemas: Record<string, any> = {
|
|
system: { schema: systemSchema, tables: Object.keys(systemSchema.collections) },
|
|
user: { schema: userSchema, tables: Object.keys(userSchema.collections) },
|
|
};
|
|
|
|
beforeAll(async () => {
|
|
db = knex({ client: MockClient }) as jest.Mocked<Knex>;
|
|
tracker = getTracker();
|
|
});
|
|
|
|
afterEach(() => {
|
|
tracker.reset();
|
|
});
|
|
|
|
describe('createOne', () => {
|
|
const item = { id: '6107c897-9182-40f7-b22e-4f044d1258d2', name: 'A.G.' };
|
|
|
|
it.each(Object.keys(schemas))(
|
|
`%s creates one item in collection as an admin, accountability: "null"`,
|
|
async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: { role: 'admin', admin: true },
|
|
schema: schemas[schema].schema,
|
|
});
|
|
|
|
tracker.on.insert(table).responseOnce(item);
|
|
|
|
const response = await itemsService.createOne(item, { emitEvents: false });
|
|
|
|
expect(tracker.history.insert.length).toBe(1);
|
|
expect(tracker.history.insert[0].bindings).toStrictEqual([item.id, item.name]);
|
|
expect(tracker.history.insert[0].sql).toBe(
|
|
`insert into "${table}" (${sqlFieldList(schemas[schema].schema, table)}) values (?, ?)`
|
|
);
|
|
|
|
expect(response).toBe(item.id);
|
|
}
|
|
);
|
|
});
|
|
|
|
describe('readOne', () => {
|
|
const rawItems = [{ id: 'b5a7dd0f-fc9f-4242-b331-83990990198f' }, { id: '6107c897-9182-40f7-b22e-4f044d1258d2' }];
|
|
|
|
describe('Permissions, Authorization, Roles', () => {
|
|
it.each(Object.keys(schemas))('%s it returns one item from tables as admin', async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
// tracker.on.select(schemas[schema].tables[1]).responseOnce([]);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: { role: 'admin', admin: true },
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, { fields: ['id', 'name'] });
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([rawItems[0].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select ${sqlFieldFormatter(
|
|
schemas[schema].schema,
|
|
table
|
|
)} from "${table}" where "${table}"."id" = ? order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual(rawItems[0]);
|
|
});
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s returns one item from tables not as admin but has permissions',
|
|
async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: table,
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: [],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id);
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([rawItems[0].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select "${table}"."id" from "${table}" where ("${table}"."id" = ?) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual(rawItems[0].id);
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))('%s returns one item with filter from tables as admin', async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: { role: 'admin', admin: true },
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, {
|
|
fields: ['id', 'name'],
|
|
filter: { name: { _eq: 'something' } },
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual(['something', rawItems[0].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select "${table}"."id", "${table}"."name" from "${table}" where "${table}"."name" = ? and "${table}"."id" = ? order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual({ id: rawItems[0].id });
|
|
});
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s returns one item with filter from tables not as admin but has field permissions',
|
|
async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: table,
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: table,
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'name'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, {
|
|
fields: ['id', 'name'],
|
|
filter: { name: { _eq: 'something' } },
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual(['something', rawItems[0].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select "${table}"."id", "${table}"."name" from "${table}" where ("${table}"."name" = ? and "${table}"."id" = ?) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual({ id: rawItems[0].id });
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s returns one item with filter on relational field from tables not as admin and has top level field permissions only',
|
|
async (schema) => {
|
|
const table = schemas[schema].tables[1];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: table,
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: table,
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, {
|
|
fields: ['id'],
|
|
filter: { uploaded_by: { _in: ['b5a7dd0f-fc9f-4242-b331-83990990198f'] } },
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([
|
|
'b5a7dd0f-fc9f-4242-b331-83990990198f',
|
|
rawItems[0].id,
|
|
100,
|
|
]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select "${table}"."id" from "${table}" where ("${table}"."uploaded_by" in (?) and "${table}"."id" = ?) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual({ id: rawItems[0].id });
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s returns one item with filter on relational field from tables not as admin and has relational permissions',
|
|
async (schema) => {
|
|
const table = schemas[schema].tables[1];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 3,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 4,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, {
|
|
fields: ['id'],
|
|
filter: { uploaded_by: { _in: ['b5a7dd0f-fc9f-4242-b331-83990990198f'] } },
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([
|
|
'b5a7dd0f-fc9f-4242-b331-83990990198f',
|
|
rawItems[0].id,
|
|
100,
|
|
]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select "${table}"."id" from "${table}" where ("${table}"."uploaded_by" in (?) and "${table}"."id" = ?) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual({ id: rawItems[0].id });
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s denies one item with filter from tables not as admin and has no field permissions',
|
|
async (schema) => {
|
|
let table = schemas[schema].tables[1];
|
|
const item = {
|
|
id: 'd66ec139-2655-48c1-9d9a-4753f98a9ee7',
|
|
uploaded_by: '6107c897-9182-40f7-b22e-4f044d1258d2',
|
|
};
|
|
let itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: { role: 'admin', admin: true },
|
|
schema: schemas[schema].schema,
|
|
});
|
|
|
|
tracker.on.insert(table).responseOnce(item);
|
|
|
|
await itemsService.createOne(item, { emitEvents: false });
|
|
|
|
table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: table,
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: table,
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
|
|
expect(() =>
|
|
itemsService.readOne(rawItems[0].id, { filter: { name: { _eq: 'something' } } })
|
|
).rejects.toThrow("You don't have permission to access this.");
|
|
expect(tracker.history.select.length).toBe(0);
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))('%s returns one item with deep filter from tables as admin', async (schema) => {
|
|
const childTable = schemas[schema].tables[1];
|
|
|
|
const childItems = [
|
|
{
|
|
id: 'd66ec139-2655-48c1-9d9a-4753f98a9ee7',
|
|
title: 'A new child item',
|
|
uploaded_by: 'b5a7dd0f-fc9f-4242-b331-83990990198f',
|
|
},
|
|
];
|
|
|
|
tracker.on.select(childTable).response(childItems);
|
|
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: { role: 'admin', admin: true },
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, {
|
|
fields: ['id', 'items.*'],
|
|
deep: { items: { _filter: { title: { _eq: childItems[0].title } } } as Query },
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(2);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([rawItems[0].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select "${table}"."id" from "${table}" where "${table}"."id" = ? order by "${table}"."id" asc limit ?`
|
|
);
|
|
expect(tracker.history.select[1].bindings).toStrictEqual([
|
|
childItems[0].title,
|
|
...rawItems.map((item) => item.id),
|
|
25000,
|
|
]);
|
|
expect(tracker.history.select[1].sql).toBe(
|
|
`select "${childTable}"."id", "${childTable}"."title", "${childTable}"."uploaded_by" from "${childTable}" where "${childTable}"."title" = ? and "${childTable}"."uploaded_by" in (?, ?) order by "${childTable}"."id" asc limit ?`
|
|
);
|
|
expect(response).toStrictEqual({ id: rawItems[0].id, items: childItems });
|
|
});
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s returns one item with deep filter from tables not as admin but has field permissions',
|
|
async (schema) => {
|
|
const childTable = schemas[schema].tables[1];
|
|
|
|
const childItems = [
|
|
{
|
|
id: 'd66ec139-2655-48c1-9d9a-4753f98a9ee7',
|
|
title: 'A new child item',
|
|
uploaded_by: 'b5a7dd0f-fc9f-4242-b331-83990990198f',
|
|
},
|
|
];
|
|
|
|
tracker.on.select(childTable).response(childItems);
|
|
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 3,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'items'],
|
|
},
|
|
{
|
|
id: 4,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'title', 'uploaded_by'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, {
|
|
fields: ['id', 'items.*'],
|
|
deep: { items: { _filter: { title: { _eq: childItems[0].title } } } as Query },
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(2);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([rawItems[0].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select "${table}"."id" from "${table}" where ("${table}"."id" = ?) order by "${table}"."id" asc limit ?`
|
|
);
|
|
expect(tracker.history.select[1].bindings).toStrictEqual([
|
|
childItems[0].title,
|
|
...rawItems.map((item) => item.id),
|
|
25000,
|
|
]);
|
|
expect(tracker.history.select[1].sql).toBe(
|
|
`select "${childTable}"."id", "${childTable}"."title", "${childTable}"."uploaded_by" from "${childTable}" where ("${childTable}"."title" = ?) and "${childTable}"."uploaded_by" in (?, ?) order by "${childTable}"."id" asc limit ?`
|
|
);
|
|
expect(response).toStrictEqual({ id: rawItems[0].id, items: childItems });
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s denies one item with deep filter from tables not as admin and has no field permissions',
|
|
async (schema) => {
|
|
const childTable = schemas[schema].tables[1];
|
|
|
|
const childItems = [
|
|
{
|
|
id: 'd66ec139-2655-48c1-9d9a-4753f98a9ee7',
|
|
title: 'A new child item',
|
|
uploaded_by: 1,
|
|
},
|
|
];
|
|
|
|
tracker.on.select(childTable).response(childItems);
|
|
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(rawItems);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 3,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'items'],
|
|
},
|
|
{
|
|
id: 4,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'uploaded_by'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
|
|
expect(() =>
|
|
itemsService.readOne(rawItems[0].id, {
|
|
fields: ['id', 'items.*'],
|
|
deep: { items: { _filter: { title: { _eq: childItems[0].title } } } as Query },
|
|
})
|
|
).rejects.toThrow("You don't have permission to access this.");
|
|
expect(tracker.history.select.length).toBe(0);
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s denies item from tables not as admin but collection accountability "all"',
|
|
async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
const customSchema = cloneDeep(schemas[schema].schema);
|
|
customSchema.collections[table].accountability = 'all';
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
},
|
|
schema: customSchema,
|
|
});
|
|
|
|
expect(() => itemsService.readOne(rawItems[0].id)).rejects.toThrow(
|
|
"You don't have permission to access this."
|
|
);
|
|
expect(tracker.history.select.length).toBe(0);
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s denies user access when permission action does not match read.',
|
|
async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: table,
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: [],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
expect(() => itemsService.readOne(rawItems[0].id)).rejects.toThrow(
|
|
"You don't have permission to access this."
|
|
);
|
|
expect(tracker.history.select.length).toBe(0);
|
|
}
|
|
);
|
|
|
|
it.each(Object.keys(schemas))('%s returns count() that is processed without role permissions', async (schema) => {
|
|
const childTable = schemas[schema].tables[1];
|
|
|
|
const childItems = [
|
|
{
|
|
items_count: 1,
|
|
id: rawItems[0].id,
|
|
},
|
|
];
|
|
|
|
tracker.on.select(childTable).response(childItems);
|
|
|
|
const table = schemas[schema].tables[0];
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'items'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'title', 'uploaded_by'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, {
|
|
fields: ['count(items)'],
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([rawItems[0].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select (select count(*) from "${childTable}" where "uploaded_by" = "${table}"."id") AS "items_count", "${table}"."id" from "${table}" where ("${table}"."id" = ?) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual({ items_count: 1 });
|
|
});
|
|
|
|
it.each(Object.keys(schemas))('%s returns count() that is processed with role permissions', async (schema) => {
|
|
const childTable = schemas[schema].tables[1];
|
|
|
|
const childItems = [
|
|
{
|
|
items_count: 1,
|
|
id: rawItems[0].id,
|
|
},
|
|
];
|
|
|
|
tracker.on.select(childTable).response(childItems);
|
|
|
|
const table = schemas[schema].tables[0];
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'read',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'items'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'read',
|
|
permissions: { _and: [{ title: { _contains: 'child' } }] },
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['id', 'title', 'uploaded_by'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readOne(rawItems[0].id, {
|
|
fields: ['count(items)'],
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([rawItems[0].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select (select count(*) from "${childTable}" where "uploaded_by" = "${table}"."id" and (("${childTable}"."title" like '%child%'))) AS "items_count", "${table}"."id" from "${table}" where ("${table}"."id" = ?) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual({ items_count: 1 });
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('readMany', () => {
|
|
const items = [
|
|
{ id: 'b5a7dd0f-fc9f-4242-b331-83990990198f', name: 'string1' },
|
|
{ id: '6107c897-9182-40f7-b22e-4f044d1258d2', name: 'string2' },
|
|
];
|
|
|
|
it.each(Object.keys(schemas))('%s it returns multiple items from tables as admin', async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce(items);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: { role: 'admin', admin: true },
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readMany([items[0].id, items[1].id], { fields: ['id', 'name'] });
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([items[0].id, items[1].id, 2]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select ${sqlFieldFormatter(
|
|
schemas[schema].schema,
|
|
table
|
|
)} from "${table}" where ("${table}"."id" in (?, ?)) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual(items);
|
|
});
|
|
|
|
describe('Global Query Params', () => {
|
|
it.each(Object.keys(schemas))(`Filter: %s _eq`, async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce([items[1]]);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: { role: 'admin', admin: true },
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readMany([], {
|
|
fields: ['id', 'name'],
|
|
filter: { id: { _eq: items[1].id } },
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([0, items[1].id, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select ${sqlFieldFormatter(
|
|
schemas[schema].schema,
|
|
table
|
|
)} from "${table}" where (1 = ? and "${table}"."id" = ?) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual([items[1]]);
|
|
});
|
|
|
|
it.each(Object.keys(schemas))(`Filter: %s _or`, async (schema) => {
|
|
const table = schemas[schema].tables[0];
|
|
|
|
tracker.on.select(table).responseOnce([items[1]]);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: { role: 'admin', admin: true },
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.readMany([], {
|
|
fields: ['id', 'name'],
|
|
filter: { _or: [{ id: { _eq: items[1].id } }, { name: { _eq: items[1].name } }] },
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(1);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([0, items[1].id, items[1].name, 100]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select ${sqlFieldFormatter(
|
|
schemas[schema].schema,
|
|
table
|
|
)} from "${table}" where (1 = ? and ("${table}"."id" = ? or "${table}"."name" = ?)) order by "${table}"."id" asc limit ?`
|
|
);
|
|
|
|
expect(response).toStrictEqual([items[1]]);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('updateOne', () => {
|
|
const item = { id: '6107c897-9182-40f7-b22e-4f044d1258d2', name: 'Item name', items: [] };
|
|
|
|
it.each(Object.keys(schemas))(
|
|
'%s updates relational field in one item without read permissions',
|
|
async (schema) => {
|
|
const childTable = schemas[schema].tables[1];
|
|
|
|
const childItem = {
|
|
id: 'd66ec139-2655-48c1-9d9a-4753f98a9ee7',
|
|
title: 'A new child item',
|
|
uploaded_by: '6107c897-9182-40f7-b22e-4f044d1258d2',
|
|
};
|
|
tracker.on.select(childTable).response([childItem]);
|
|
tracker.on.update(childTable).response(childItem);
|
|
|
|
const table = schemas[schema].tables[0];
|
|
schemas[schema].accountability = null;
|
|
|
|
tracker.on.select(table).response([item]);
|
|
|
|
const itemsService = new ItemsService(table, {
|
|
knex: db,
|
|
accountability: {
|
|
role: 'admin',
|
|
admin: false,
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 2,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'create',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 3,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[0],
|
|
action: 'update',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
{
|
|
id: 4,
|
|
role: 'admin',
|
|
collection: schemas[schema].tables[1],
|
|
action: 'update',
|
|
permissions: {},
|
|
validation: {},
|
|
presets: {},
|
|
fields: ['*'],
|
|
},
|
|
],
|
|
},
|
|
schema: schemas[schema].schema,
|
|
});
|
|
const response = await itemsService.updateOne(item.id, {
|
|
items: [],
|
|
});
|
|
|
|
expect(tracker.history.select.length).toBe(4);
|
|
expect(tracker.history.select[0].bindings).toStrictEqual([item.id, 1]);
|
|
expect(tracker.history.select[0].sql).toBe(
|
|
`select "${table}"."id", "${table}"."name" from "${table}" where (("${table}"."id" in (?))) order by "${table}"."id" asc limit ?`
|
|
);
|
|
expect(tracker.history.select[1].bindings).toStrictEqual([item.id, 25000]);
|
|
expect(tracker.history.select[1].sql).toBe(
|
|
`select "${childTable}"."uploaded_by", "${childTable}"."id" from "${childTable}" where "${childTable}"."uploaded_by" in (?) order by "${childTable}"."id" asc limit ?`
|
|
);
|
|
expect(tracker.history.select[2].bindings).toStrictEqual([item.id, 1, 100]);
|
|
expect(tracker.history.select[2].sql).toBe(
|
|
`select "${childTable}"."id" from "${childTable}" where ("${childTable}"."uploaded_by" = ? and 1 = ?) order by "${childTable}"."id" asc limit ?`
|
|
);
|
|
expect(tracker.history.select[3].bindings).toStrictEqual([childItem.id, 1]);
|
|
expect(tracker.history.select[3].sql).toBe(
|
|
`select "${childTable}"."id", "${childTable}"."title", "${childTable}"."uploaded_by" from "${childTable}" where (("${childTable}"."id" in (?))) order by "${childTable}"."id" asc limit ?`
|
|
);
|
|
expect(tracker.history.update[0].bindings).toStrictEqual([null, childItem.id]);
|
|
expect(tracker.history.update[0].sql).toBe(`update "${childTable}" set "uploaded_by" = ? where "id" in (?)`);
|
|
|
|
expect(response).toStrictEqual(item.id);
|
|
}
|
|
);
|
|
});
|
|
});
|