Isis Lovecruft
ce5ff27681
Make serde_bytes/alloc dependent on alloc feature.
...
Fixup for PR #149 .
2020-10-28 00:04:15 +00:00
isis agora lovecruft
50b26f0bb4
Merge pull request #149 from xu-cheng/no_std
...
fix serde in no_std
2020-10-28 00:02:02 +00:00
isis agora lovecruft
95db7d8eae
Merge pull request #153 from huitseeker/non_repudiation
...
[test-only] Add test showing non-repudiation for verify, verify_strict
2020-10-27 23:59:26 +00:00
François Garillot
da6c7e114f
[test-only] Add test showing the non-repudiation property of the signature verifications used in PublicKey::verify and PublicKey::verify_strict.
...
This PR is a follow-up of #98 , which aims to demonstrate the issue brought by small-order public keys. It shows an example of crafting a (public_key, signature) that verifies against two distinct messages using `verify`, but fails using `verify_strict`.
This has consequences on the possibility to repudiate a signed contract of blockchain transactions.
For more details, see:
https://eprint.iacr.org/2020/1244
Joint work with @kchalkias @valerini
2020-10-14 17:28:51 -04:00
Cheng XU
6ce6519287
fix serde in no_std
2020-09-21 19:16:01 -07:00
Isis Lovecruft
91234fcdc8
Merge branch 'master' into develop
2020-09-22 02:01:10 +00:00
Isis Lovecruft
925eb9ea56
Merge branch 'release/1.0.1'
2020-09-22 02:00:50 +00:00
Isis Lovecruft
1042cb60a0
Bump ed25519-dalek version to 1.0.1.
1.0.1
2020-09-22 01:56:35 +00:00
Isis Lovecruft
8c15bce61d
Actually, we use unsafe{} in one test.
2020-09-22 01:54:44 +00:00
isis agora lovecruft
97c22f2d07
Merge pull request #146 from xu-cheng/serde2
...
Fix serde implementation for serde_json
2020-09-22 01:49:58 +00:00
isis agora lovecruft
a9ebf7f53e
Merge pull request #148 from isislovecruft/feature/forbid-unsafe
...
Add #![forbid(unsafe_code)].
2020-09-22 01:39:51 +00:00
isis agora lovecruft
1335f3a859
Merge pull request #147 from isislovecruft/fix/deterministic-batch-malleability
...
batch verification malleability issue when used with fully deterministic nonce generation
2020-09-22 01:38:22 +00:00
Isis Lovecruft
d6ff6de2cf
Add #![forbid(unsafe_code)].
...
CLOSES https://github.com/dalek-cryptography/ed25519-dalek/issues/144
2020-09-22 01:36:49 +00:00
Cheng XU
69eccda444
Fix serde implementation for serde_json
...
We use the [serde_bytes](https://github.com/serde-rs/bytes ) crate for
serialization implementations, which simplifies codes and fixes issues
for serde_json.
2020-09-21 18:26:59 -07:00
Cheng XU
008c9680f6
Update tests for serde
...
* Upgrade bincode to 1.0
* Add more serde tests including json serialization.
2020-09-21 18:26:59 -07:00
Isis Lovecruft
b5a15bf451
Feature gate key generation on the "rand" dependency.
...
See https://github.com/dalek-cryptography/ed25519-dalek/pull/139 .
2020-09-21 23:53:56 +00:00
Isis Lovecruft
6609642036
Enable rand crate by default.
...
See https://github.com/dalek-cryptography/ed25519-dalek/pull/139 .
2020-09-21 23:53:29 +00:00
isis agora lovecruft
7155c07afa
Merge pull request #139 from garbageslam/fixup_rand_usage
...
Make `use rand::...` gated on `cfg(feature = "rand")`
2020-09-21 23:47:26 +00:00
isis agora lovecruft
036c18a01b
Merge pull request #145 from isislovecruft/fix/rand-nightly-breakage
...
Workaround for rand crate "nightly" feature breakage.
2020-09-21 23:35:21 +00:00
Isis Lovecruft
5d7bc29ba2
Workaround for rand crate "nightly" feature breakage.
...
Cf. https://github.com/rust-random/rand/issues/1047
2020-09-21 23:25:15 +00:00
Isis Lovecruft
a02190adf3
Document that we include the message lengths in the transcript.
2020-09-21 22:10:03 +00:00
Isis Lovecruft
57a5473cb0
Fix and document malleability issue in deterministic batch_verify().
...
Thank you to @real_or_random and @jonasnick for initially pointing it
out and ensuing discussion.
2020-09-21 22:09:27 +00:00
isis agora lovecruft
bd572dcd52
Merge pull request #142 from 35359595/master
...
check_scalar bug fix for legacy_compatibility feature
2020-09-10 01:36:55 +00:00
Ivan Temchenko
da959c041d
check_scalar bug fix for legacy_compatibility feature
2020-08-24 16:33:04 +02:00
Isis Lovecruft
5fe7c88303
Merge branch 'master' into develop
2020-08-20 22:54:10 +00:00
Isis Lovecruft
75a199e5a0
Merge branch 'release/1.0.0'
2020-08-20 22:54:01 +00:00
Isis Lovecruft
952bdd062f
Release ed25519-dalek version 1.0.0.
1.0.0
2020-08-20 22:46:58 +00:00
Isis Lovecruft
1c97dac4dc
Update to curve25519-dalek version 3.
2020-08-20 21:19:21 +00:00
Chris Beck
bb82d616de
Make use rand::... gated on cfg(feature = "rand")
...
This is no longer actively breaking our no_std build, but I think
it's still technically a minor bug, and further case of issue #108
2020-08-04 11:58:07 -07:00
Isis Lovecruft
04116902cd
Merge branch 'master' into develop
2020-07-16 23:31:18 +00:00
Isis Lovecruft
ae0b48b0cd
Merge branch 'release/1.0.0-pre.4'
2020-07-16 23:31:08 +00:00
Isis Lovecruft
5f22d899a0
Bump ed25519-dalek version to 1.0.0-pre.4.
1.0.0-pre.4
2020-07-16 23:25:09 +00:00
Isis Lovecruft
5458ebef88
Fix no_std issue with new error types.
2020-07-16 23:18:00 +00:00
Isis Lovecruft
d3a5b3bd81
Remove unsafe trait impls.
2020-07-16 23:02:27 +00:00
Isis Lovecruft
7243d7151d
Fix handling of external error types.
2020-07-16 22:19:40 +00:00
Isis Lovecruft
69004599c5
Fix misnamed error type.
2020-07-16 21:49:14 +00:00
Isis Lovecruft
b84f1df47b
Merge branch 'fix/ed25519ph-context' into develop
2020-07-15 17:44:54 +00:00
Isis Lovecruft
b8f36d48d8
Fix proc_macro crate name resolution for serde integration tests.
2020-07-15 17:39:23 +00:00
Isis Lovecruft
e7a88c2c7f
Try compiling tests using serde_crate instead.
2020-07-14 23:58:35 +00:00
Isis Lovecruft
980ed6445f
Add missing toml dev-dependency.
2020-07-14 22:23:31 +00:00
Isis Lovecruft
97787d3716
Remove impl of std::error::Error for SignatureError.
...
We're now aliasing SignatureError to the error type from the signature
crate.
2020-07-14 00:37:56 +00:00
Isis Lovecruft
989c5e4c18
Fix ed25519ph context length error handling in sign_prehashed().
...
RFC8032 specifies that the context cannot be greater than 255 octets,
but in the previous implementation in ed25519-dalek, this error would
only be caught by a debug_assert. This changes the sign_prehashed()
function to return a Result so that the error can be handled at
runtime and the library no longer allows misuse by creating signatures
that other libraries cannot handle.
2020-07-14 00:25:40 +00:00
isis agora lovecruft
33bb760ea8
Merge pull request #134 from isislovecruft/fix/signature-error
...
Impl std::error::Error for SignatureError.
2020-07-13 23:40:12 +00:00
Isis Lovecruft
f1d8576f12
Impl std::error::Error for SignatureError.
2020-07-13 23:19:55 +00:00
Isis Lovecruft
3a9435df94
Fixup serde and ed25519 trait errors in tests/benches.
2020-07-13 23:16:30 +00:00
Isis Lovecruft
84047448da
Merge remote-tracking branch 'tarcieri/ed25519-crate' into develop
2020-07-13 23:00:23 +00:00
isis agora lovecruft
8ebbbe5f5b
Merge pull request #127 from huitseeker/update-merlin
...
Updates the merlin dependency to ^2 and the correct repo
2020-06-30 22:58:39 +00:00
isis agora lovecruft
005fc35f52
Merge pull request #116 from NikVolf/nv-fix-alloc
...
Fix alloc feature compilation
2020-06-30 22:51:07 +00:00
Isis Lovecruft
c5386c0df9
Merge branch 'master' into develop
2020-06-30 22:44:29 +00:00
Isis Lovecruft
3ffa9ff530
Merge remote-tracking branch 'dalek/master'
2020-06-30 22:43:56 +00:00