github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove gin_helper::Arguments (#48374)

Browse Source 
* refactor: make api::Clipboard::GetClipboardBuffer() private

* refactor: move GetClipboadBuffer() into anonymous namespace

* refactor: use gin::Arguments in StopRecording()

* refactor: use gin::Arguments in ImageView::New()

* refactor: use gin::Arguments in AppendSwitch()

* refactor: use gin::Arguments WebContentsView::New()

* refactor: make gin::Arguments arg const in WrappableBase::InitWithArgs()

This makes explicit that we are using it for wrapper + isolate, not the args values

* refactor: remove gin_helper::Arguments arg from ExposeAPI()

refactor: remove gin_helper::Arguments arg from ExposeAPIInWorld()

* refactor: remove gin_helper::Arguments arg from ElectronBindings::GetSystemMemoryInfo()

* refactor: remove gin_helper::Arguments arg from preload_utils::GetBinding()

* refactor: use gin::Arguments in OpenExternal()

* refactor: use gin::Arguments in ExecuteInWorld()

* refactor: use gin::Arguments in ExecuteJavaScript()

* refactor: use gin::Arguments in InvokeNew()

* refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld()

* refactor: remove unused GetNextArgument() marshaller for gin_helper::Arguments

* refactor: remove unused #include gin_helper/arguments.h

* chore: remove unused gin_helper::Arguments

* fixup! refactor: use gin::Arguments in ExecuteJavaScriptInIsolatedWorld()

Xref: https://github.com/electron/electron/pull/48447
This commit is contained in:
Charles Kerr
2025-10-03 14:10:29 -05:00
committed by GitHub
parent 7cb1552614
commit 01cab978f7
22 changed files with 76 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/views/electron_api_image_view.cc
View File

@@ -25,7 +25,7 @@ void ImageView::SetImage(const gfx::Image& image) {
}
// static
gin_helper::WrappableBase* ImageView::New(gin_helper::Arguments* args) {
gin_helper::WrappableBase* ImageView::New(gin::Arguments* const args) {
// Constructor call.
auto* view = new ImageView();
view->InitWithArgs(args);

7
shell/browser/api/views/electron_api_image_view.h
View File

@@ -13,8 +13,11 @@ namespace gfx {
class Image;
}
namespace gin_helper {
namespace gin {
class Arguments;
} // namespace gin
namespace gin_helper {
class WrappableBase;
} // namespace gin_helper
@@ -22,7 +25,7 @@ namespace electron::api {
class ImageView : public View {
public:
static gin_helper::WrappableBase* New(gin_helper::Arguments* args);
static gin_helper::WrappableBase* New(gin::Arguments* args);
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);