From 039903c6b2b6533aff36230ffb80fba8ef280c2a Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Wed, 1 Oct 2014 15:51:32 +0800 Subject: [PATCH] mac: Don't create button without title, fixes #631 --- atom/browser/ui/message_box_mac.mm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/atom/browser/ui/message_box_mac.mm b/atom/browser/ui/message_box_mac.mm index bc2c5c692c..147a09d0d2 100644 --- a/atom/browser/ui/message_box_mac.mm +++ b/atom/browser/ui/message_box_mac.mm @@ -75,6 +75,9 @@ NSAlert* CreateNSAlert(NativeWindow* parent_window, for (size_t i = 0; i < buttons.size(); ++i) { NSString* title = base::SysUTF8ToNSString(buttons[i]); + // An empty title causes crash on OS X. + if (buttons[i].empty()) + title = @"(empty)"; NSButton* button = [alert addButtonWithTitle:title]; [button setTag:i]; }