github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-02-17 02:21:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: detach webview instead of destroying it

Browse Source 
Chromium no longer cleans up everything when a guest webcontents is
destroyed, we have to force detaching it and let Chromium destroy everything.
This commit is contained in:
Cheng Zhao
2019-01-12 15:50:33 +09:00
committed by Jeremy Apthorp
parent 5e043812ef
commit 03d499bf34
7 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
patches/common/chromium/disable_detach_webview_frame.patch
View File

@@ -9,6 +9,8 @@ This is part of the fixes for https://github.com/electron/electron/issues/14211.
We should revisit this bug after upgrading to newer versions of Chrome,
this patch was introduced in Chrome 66.
Update(zcbenz): The bug is still in Chrome 72.
diff --git a/content/browser/frame_host/render_frame_proxy_host.cc b/content/browser/frame_host/render_frame_proxy_host.cc
index cfa3fd15714c3743cb9d2900b35570c94545fa87..80785902890c57ffae2fa841831d3bd60a8fa11a 100644
--- a/content/browser/frame_host/render_frame_proxy_host.cc