github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

build: match upstream with unsafe buffer paths (#45853)

Browse Source 
* build: match upstream with unsafe buffer paths

* Don't assume STL iterators are pointers

Refs https://issues.chromium.org/issues/328308661

* chore: spanify process_singleton_win.cc
This commit is contained in:
Robo
2025-03-07 06:04:18 +09:00
committed by GitHub
parent d987bee007
commit 041ada1586
13 changed files with 44 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_app.cc
View File

@@ -405,7 +405,7 @@ int GetPathConstant(std::string_view name) {
{"videos", chrome::DIR_USER_VIDEOS},
});
// clang-format on
const auto* iter = Lookup.find(name);
auto iter = Lookup.find(name);
return iter != Lookup.end() ? iter->second : -1;
}

2
shell/browser/api/electron_api_system_preferences_win.cc
View File

@@ -129,7 +129,7 @@ std::string SystemPreferences::GetColor(gin_helper::ErrorThrower thrower,
{"window-text", COLOR_WINDOWTEXT},
});
if (const auto* iter = Lookup.find(color); iter != Lookup.end())
if (auto iter = Lookup.find(color); iter != Lookup.end())
return ToRGBAHex(color_utils::GetSysSkColor(iter->second));
thrower.ThrowError("Unknown color: " + color);

2
shell/browser/api/electron_api_web_request.cc
View File

@@ -80,7 +80,7 @@ struct UserData : public base::SupportsUserData::Data {
};
extensions::WebRequestResourceType ParseResourceType(std::string_view value) {
if (const auto* iter = ResourceTypes.find(value); iter != ResourceTypes.end())
if (auto iter = ResourceTypes.find(value); iter != ResourceTypes.end())
return iter->second;
return extensions::WebRequestResourceType::OTHER;

2
shell/browser/ui/views/client_frame_view_linux.cc
View File

@@ -416,7 +416,7 @@ void ClientFrameViewLinux::LayoutButtonsOnSide(
}
for (views::FrameButton frame_button : frame_buttons) {
auto* button =
auto button =
std::ranges::find_if(nav_buttons_, [&](const NavButton& test) {
return test.type != skip_type && test.frame_button == frame_button;
});