github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix clang-tidy warnings (#38079)

Browse Source 
* chore: fix clang-tidy warnings

* refactor: avoid need for NOLINTNEXTLINE
This commit is contained in:
David Sanders
2023-04-26 07:09:54 -07:00
committed by GitHub
parent fe5cdd39d6
commit 08593fd2bd
20 changed files with 41 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/common/gin_helper/trackable_object.cc
View File

@@ -21,7 +21,7 @@ class IDUserData : public base::SupportsUserData::Data {
public:
explicit IDUserData(int32_t id) : id_(id) {}
operator int32_t() const { return id_; }
explicit operator int32_t() const { return id_; }
private:
int32_t id_;
@@ -58,7 +58,7 @@ int32_t TrackableObjectBase::GetIDFromWrappedClass(
auto* id =
static_cast<IDUserData*>(wrapped->GetUserData(kTrackedObjectKey));
if (id)
return *id;
return int32_t(*id);
}
return 0;
}

2
shell/common/platform_util_linux.cc
View File

@@ -61,7 +61,7 @@ class ShowItemHelper {
return *instance;
}
ShowItemHelper() {}
ShowItemHelper() = default;
ShowItemHelper(const ShowItemHelper&) = delete;
ShowItemHelper& operator=(const ShowItemHelper&) = delete;