github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: pass base::Value by value in JS API implementations (#20809)

Browse Source 
* refactor: move the arg instead of const reference it

* refactor: avoid unnecessary copies of base::Value in arg

* refactor: pass-by-value in dict_util

* refactor: avoid unnecessary reference
This commit is contained in:
Cheng Zhao
2019-10-30 14:30:59 +09:00
committed by GitHub
parent c03ed6d3a1
commit 0ab9cc30d2
26 changed files with 108 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/browser.cc
View File

@@ -151,7 +151,7 @@ void Browser::WillFinishLaunching() {
observer.OnWillFinishLaunching();
}
void Browser::DidFinishLaunching(const base::DictionaryValue& launch_info) {
void Browser::DidFinishLaunching(base::DictionaryValue launch_info) {
// Make sure the userData directory is created.
base::ThreadRestrictions::ScopedAllowIO allow_io;
base::FilePath user_data;