github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: pass base::Value by value in JS API implementations (#20809)

Browse Source 
* refactor: move the arg instead of const reference it

* refactor: avoid unnecessary copies of base::Value in arg

* refactor: pass-by-value in dict_util

* refactor: avoid unnecessary reference
This commit is contained in:
Cheng Zhao
2019-10-30 14:30:59 +09:00
committed by GitHub
parent c03ed6d3a1
commit 0ab9cc30d2
26 changed files with 108 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/browser_linux.cc
View File

@@ -216,8 +216,8 @@ void Browser::ShowAboutPanel() {
gtk_widget_destroy(dialogWidget);
}
void Browser::SetAboutPanelOptions(const base::DictionaryValue& options) {
about_panel_options_ = options.Clone();
void Browser::SetAboutPanelOptions(base::DictionaryValue options) {
about_panel_options_ = std::move(options);
}
} // namespace electron