github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: replace .forEach() with for-of (#39691)

Browse Source 
* refactor: replace `.forEach()` with `for-of`

* refactor docs/fiddles/features/web-hid/renderer.js
This commit is contained in:
Milan Burda
2023-08-31 16:36:43 +02:00
committed by GitHub
parent 7858921a1f
commit 0b0707145b
32 changed files with 144 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/browser/api/menu.ts
View File

@@ -153,9 +153,9 @@ Menu.prototype.insert = function (pos, item) {
Menu.prototype._callMenuWillShow = function () {
if (this.delegate) this.delegate.menuWillShow(this);
this.items.forEach(item => {
for (const item of this.items) {
if (item.submenu) item.submenu._callMenuWillShow();
});
}
};
/* Static Methods */
@@ -196,13 +196,13 @@ Menu.buildFromTemplate = function (template) {
const filtered = removeExtraSeparators(sorted);
const menu = new Menu();
filtered.forEach(item => {
for (const item of filtered) {
if (item instanceof MenuItem) {
menu.append(item);
} else {
menu.append(new MenuItem(item));
}
});
}
return menu;
};
@@ -280,9 +280,9 @@ function insertItemByType (this: MenuType, item: MenuItem, pos: number) {
enumerable: true,
get: () => checked.get(item),
set: () => {
this.groupsMap[item.groupId].forEach(other => {
for (const other of this.groupsMap[item.groupId]) {
if (other !== item) checked.set(other, false);
});
}
checked.set(item, true);
}
});