From 0de40febabce34e09a96ae3a10bf105947892eb5 Mon Sep 17 00:00:00 2001
From: Cheng Zhao <zcbenz@gmail.com>
Date: Fri, 27 Dec 2013 14:57:53 +0800
Subject: [PATCH] Add basic support for window.open's features.

---
 renderer/lib/init.coffee | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/renderer/lib/init.coffee b/renderer/lib/init.coffee
index 4d03ab06ff..30e1de4e88 100644
--- a/renderer/lib/init.coffee
+++ b/renderer/lib/init.coffee
@@ -61,8 +61,25 @@ window.onerror = (error) ->
     false
 
 # Override default window.open.
-window.open = (url) ->
+window.open = (url, name, features) ->
+  options = {}
+  for feature in features.split ','
+    [name, value] = feature.split '='
+    options[name] =
+      if value is 'yes'
+        true
+      else if value is 'no'
+        false
+      else
+        value
+
+  options.x ?= options.left
+  options.y ?= options.top
+  options.title ?= name
+  options.width ?= 800
+  options.height ?= 600
+
   BrowserWindow = require('remote').require 'browser-window'
-  browser = new BrowserWindow width: 800, height: 600
+  browser = new BrowserWindow options
   browser.loadUrl url
   browser