github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: modernize Value usage in converters (#34794)

Browse Source 
* chore: modernize Value usage in converters

* Date is parsed as an empty object now
This commit is contained in:
Jeremy Rose
2022-07-05 08:25:18 -07:00
committed by GitHub
parent d28ed0da20
commit 0ee7f14190
34 changed files with 203 additions and 829 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/api/electron_api_session.cc
View File

@@ -1160,7 +1160,7 @@ gin::Handle<Session> Session::CreateFrom(
// static
gin::Handle<Session> Session::FromPartition(v8::Isolate* isolate,
const std::string& partition,
base::DictionaryValue options) {
base::Value::Dict options) {
ElectronBrowserContext* browser_context;
if (partition.empty()) {
browser_context =
@@ -1265,7 +1265,7 @@ v8::Local<v8::Value> FromPartition(const std::string& partition,
args->ThrowTypeError("Session can only be received when app is ready");
return v8::Null(args->isolate());
}
base::DictionaryValue options;
base::Value::Dict options;
args->GetNext(&options);
return Session::FromPartition(args->isolate(), partition, std::move(options))
.ToV8();