From 14051ff9458488938f122e1c66ee1bcaac98ebbc Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Wed, 1 Apr 2020 22:45:39 +0900 Subject: [PATCH] test: do not trigger unhandled promise rejections (#22922) --- spec-main/api-web-request-spec.ts | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/spec-main/api-web-request-spec.ts b/spec-main/api-web-request-spec.ts index f7bee29213..89fd829cba 100644 --- a/spec-main/api-web-request-spec.ts +++ b/spec-main/api-web-request-spec.ts @@ -135,16 +135,16 @@ describe('webRequest module', () => { await ajax(defaultURL + 'serverRedirect'); }); - it('works with file:// protocol', (done) => { + it('works with file:// protocol', async () => { ses.webRequest.onBeforeRequest((details, callback) => { callback({ cancel: true }); - done(); }); - ajax(url.format({ + const fileURL = url.format({ pathname: path.join(fixturesPath, 'blank.html').replace(/\\/g, '/'), protocol: 'file', slashes: true - })); + }); + await expect(ajax(fileURL)).to.eventually.be.rejectedWith('404'); }); }); @@ -207,22 +207,24 @@ describe('webRequest module', () => { await ajax(defaultURL); }); - it('works with file:// protocol', (done) => { + it('works with file:// protocol', async () => { const requestHeaders = { Test: 'header' }; + let onSendHeadersCalled = false; ses.webRequest.onBeforeSendHeaders((details, callback) => { callback({ requestHeaders: requestHeaders }); }); ses.webRequest.onSendHeaders((details) => { expect(details.requestHeaders).to.deep.equal(requestHeaders); - done(); + onSendHeadersCalled = true; }); - ajax(url.format({ + await ajax(url.format({ pathname: path.join(fixturesPath, 'blank.html').replace(/\\/g, '/'), protocol: 'file', slashes: true })); + expect(onSendHeadersCalled).to.be.true(); }); });