From 156a97b80d1fe1cf701d035e6481dc00fbd56677 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Fri, 18 May 2018 10:29:28 -0700 Subject: [PATCH] fix: Menu.setApplicationMenu(null) crash on Linux (#12983) --- atom/browser/ui/views/global_menu_bar_x11.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/atom/browser/ui/views/global_menu_bar_x11.cc b/atom/browser/ui/views/global_menu_bar_x11.cc index 13cf167be3..4358601b59 100644 --- a/atom/browser/ui/views/global_menu_bar_x11.cc +++ b/atom/browser/ui/views/global_menu_bar_x11.cc @@ -209,7 +209,9 @@ void GlobalMenuBarX11::SetMenu(AtomMenuModel* menu_model) { DbusmenuMenuitem* root_item = menuitem_new(); menuitem_property_set(root_item, kPropertyLabel, "Root"); menuitem_property_set_bool(root_item, kPropertyVisible, true); - BuildMenuFromModel(menu_model, root_item); + if (menu_model != nullptr) { + BuildMenuFromModel(menu_model, root_item); + } server_set_root(server_, root_item); g_object_unref(root_item);