github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-08 23:18:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: addChildView() crashes when adding a closed WebContentsView (#47099)

Browse Source 
fix: addChildView() crashes when add a closed WebContentsView
This commit is contained in:
Sta Zhu
2025-06-03 16:53:25 +08:00
committed by GitHub
parent d1e64c37a2
commit 158176f0f3
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
shell/browser/api/electron_api_view.cc
View File

@@ -216,6 +216,12 @@ void View::AddChildViewAt(gin::Handle<View> child,
if (!view_)
return;
if (!child->view()) {
gin_helper::ErrorThrower(isolate()).ThrowError(
"Can't add a destroyed child view to a parent view");
return;
}
// This will CHECK and crash in View::AddChildViewAtImpl if not handled here.
if (view_ == child->view()) {
gin_helper::ErrorThrower(isolate()).ThrowError(