From 161b4e752b4c5f9344f1fc67fa3c52ec6b51c58e Mon Sep 17 00:00:00 2001 From: Ales Pergl Date: Wed, 5 Apr 2017 13:15:06 +0200 Subject: [PATCH] Address cpplint issue "public: should be indented +1 space inside class NotificationPresenterWin7 [whitespace/indent] [3]" --- .../browser/win/notification_presenter_win7.h | 4 ++-- .../desktop_notification_controller.h | 14 +++++++------- .../win/win32_desktop_notifications/toast.h | 6 +++--- brightray/browser/win/win32_notification.h | 4 ++-- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/brightray/browser/win/notification_presenter_win7.h b/brightray/browser/win/notification_presenter_win7.h index 8c7bc9aeca..5021d2c41c 100644 --- a/brightray/browser/win/notification_presenter_win7.h +++ b/brightray/browser/win/notification_presenter_win7.h @@ -9,7 +9,7 @@ class Win32Notification; class NotificationPresenterWin7 : public NotificationPresenter, public DesktopNotificationController { -public: + public: NotificationPresenterWin7() = default; Win32Notification* GetNotificationObjectByRef( @@ -17,7 +17,7 @@ public: Win32Notification* GetNotificationObjectByTag(const std::string& tag); -private: + private: DISALLOW_COPY_AND_ASSIGN(NotificationPresenterWin7); brightray::Notification* CreateNotificationObject( diff --git a/brightray/browser/win/win32_desktop_notifications/desktop_notification_controller.h b/brightray/browser/win/win32_desktop_notifications/desktop_notification_controller.h index 9320283ea4..88daf5d2ed 100644 --- a/brightray/browser/win/win32_desktop_notifications/desktop_notification_controller.h +++ b/brightray/browser/win/win32_desktop_notifications/desktop_notification_controller.h @@ -10,7 +10,7 @@ namespace brightray { struct NotificationData; class DesktopNotificationController { -public: + public: DesktopNotificationController(unsigned maximumToasts = 3); ~DesktopNotificationController(); @@ -20,18 +20,18 @@ public: void CloseNotification(Notification& notification); // Event handlers -- override to receive the events -private: + private: virtual void OnNotificationClosed(Notification& notification) {} virtual void OnNotificationClicked(Notification& notification) {} virtual void OnNotificationDismissed(Notification& notification) {} -private: + private: static HINSTANCE RegisterWndClasses(); void StartAnimation(); HFONT GetCaptionFont(); HFONT GetBodyFont(); -private: + private: enum TimerID { TimerID_Animate = 1 }; @@ -76,7 +76,7 @@ private: HWND GetToast(const NotificationData* data) const; void DestroyToast(ToastInstance& inst); -private: + private: static constexpr const TCHAR class_name_[] = TEXT("DesktopNotificationController"); @@ -88,7 +88,7 @@ private: }; class DesktopNotificationController::Notification { -public: + public: Notification() = default; Notification(const std::shared_ptr& data); @@ -97,7 +97,7 @@ public: void Close(); void Set(std::wstring caption, std::wstring bodyText, HBITMAP image); -private: + private: std::shared_ptr data_; friend class DesktopNotificationController; diff --git a/brightray/browser/win/win32_desktop_notifications/toast.h b/brightray/browser/win/win32_desktop_notifications/toast.h index 926427c734..00e5733b6d 100644 --- a/brightray/browser/win/win32_desktop_notifications/toast.h +++ b/brightray/browser/win/win32_desktop_notifications/toast.h @@ -4,7 +4,7 @@ namespace brightray { class DesktopNotificationController::Toast { -public: + public: static void Register(HINSTANCE hInstance); static HWND Create(HINSTANCE hInstance, std::shared_ptr& data); @@ -40,7 +40,7 @@ public: return is_highlighted_; } -private: + private: enum TimerID { TimerID_AutoDismiss = 1 }; @@ -67,7 +67,7 @@ private: float AnimateEaseOut(); float AnimateStackCollapse(); -private: + private: static constexpr const TCHAR class_name_[] = TEXT("DesktopNotificationToast"); diff --git a/brightray/browser/win/win32_notification.h b/brightray/browser/win/win32_notification.h index 02f15c915f..c45352d145 100644 --- a/brightray/browser/win/win32_notification.h +++ b/brightray/browser/win/win32_notification.h @@ -5,7 +5,7 @@ namespace brightray { class Win32Notification : public brightray::Notification { -public: + public: Win32Notification(NotificationDelegate* delegate, NotificationPresenterWin7* presenter) : Notification(delegate, presenter) { @@ -23,7 +23,7 @@ public: return tag_; } -private: + private: DISALLOW_COPY_AND_ASSIGN(Win32Notification); DesktopNotificationController::Notification notification_ref_; std::string tag_;