github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: app.dock.setIcon() crash before app ready (#36279)

Browse Source 
fix: dock.setIcon() crash before app ready
This commit is contained in:
Shelley Vohr
2022-11-09 17:13:24 +01:00
committed by GitHub
parent 5fc3ed936e
commit 1b1609aa0f
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
shell/browser/browser_mac.mm
View File

@@ -447,6 +447,13 @@ void Browser::DockSetIcon(v8::Isolate* isolate, v8::Local<v8::Value> icon) {
image = native_image->image(); image = native_image->image();
} }
// This is needed when this fn is called before the browser
// process is ready, since supported scales are normally set
// by ui::ResourceBundle::InitSharedInstance
// during browser process startup.
if (!is_ready())
gfx::ImageSkia::SetSupportedScales({1.0f});
[[AtomApplication sharedApplication] [[AtomApplication sharedApplication]
setApplicationIconImage:image.AsNSImage()]; setApplicationIconImage:image.AsNSImage()];
} }