From 1dbaf4987e91bd7b35a2d50d80a5078b6769effd Mon Sep 17 00:00:00 2001
From: Kevin Sawicki <kevinsawicki@gmail.com>
Date: Thu, 8 Sep 2016 16:48:30 -0700
Subject: [PATCH] Don't resolve empty src/preload attribute values

---
 lib/renderer/web-view/web-view-attributes.js | 1 +
 spec/webview-spec.js                         | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/lib/renderer/web-view/web-view-attributes.js b/lib/renderer/web-view/web-view-attributes.js
index e918578900..01eb77727c 100644
--- a/lib/renderer/web-view/web-view-attributes.js
+++ b/lib/renderer/web-view/web-view-attributes.js
@@ -9,6 +9,7 @@ const remote = require('electron').remote
 var a = document.createElement('a')
 
 var resolveURL = function (url) {
+  if (url === '') return ''
   a.href = url
   return a.href
 }
diff --git a/spec/webview-spec.js b/spec/webview-spec.js
index 3629c5ec2e..2083d6d2eb 100644
--- a/spec/webview-spec.js
+++ b/spec/webview-spec.js
@@ -80,6 +80,10 @@ describe('<webview> tag', function () {
       assert.equal(webview.src, '')
       webview.src = ''
       assert.equal(webview.src, '')
+      webview.src = null
+      assert.equal(webview.src, '')
+      webview.src = undefined
+      assert.equal(webview.src, '')
     })
   })
 
@@ -209,6 +213,10 @@ describe('<webview> tag', function () {
       assert.equal(webview.preload, '')
       webview.preload = ''
       assert.equal(webview.preload, '')
+      webview.preload = null
+      assert.equal(webview.preload, '')
+      webview.preload = undefined
+      assert.equal(webview.preload, '')
     })
   })