github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 2) (#47879)

Browse Source 
* refactor: add a v8::Isolate* arg to Constructible::GetConstructor()

* refactor: add a v8::Isolate* arg to NodeBindings::Initialize()

This is needed for the GetConstructor() call

* refactor: avoid v8::Context::GetIsolate() call in GetIpcObject() by taking it as an arg

* refactor: avoid v8::Context::GetIsolate() call in ipc_native::EmitIPCEvent() by taking it as an arg
This commit is contained in:
Charles Kerr
2025-07-28 10:22:27 -05:00
committed by GitHub
parent 084c6ef549
commit 2255bb620a
18 changed files with 42 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
shell/browser/api/electron_api_service_worker_main.cc
View File

@@ -356,7 +356,8 @@ void Initialize(v8::Local<v8::Object> exports,
void* priv) {
v8::Isolate* const isolate = electron::JavascriptEnvironment::GetIsolate();
gin_helper::Dictionary dict{isolate, exports};
dict.Set("ServiceWorkerMain", ServiceWorkerMain::GetConstructor(context));
dict.Set("ServiceWorkerMain",
ServiceWorkerMain::GetConstructor(isolate, context));
}
} // namespace