github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: DCHECK minimizing parent window with non-modal child (#38508)

Browse Source 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot]
2023-05-31 10:28:44 -04:00
committed by GitHub
parent eece0dcbe1
commit 2281fbbe6c
5 changed files with 107 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/ui/cocoa/electron_ns_window_delegate.mm
View File

@@ -239,6 +239,7 @@ using FullScreenTransitionState =
level_ = [window level];
shell_->SetWindowLevel(NSNormalWindowLevel);
shell_->UpdateWindowOriginalFrame();
shell_->DetachChildren();
}
- (void)windowDidMiniaturize:(NSNotification*)notification {
@@ -248,6 +249,7 @@ using FullScreenTransitionState =
- (void)windowDidDeminiaturize:(NSNotification*)notification {
[super windowDidDeminiaturize:notification];
shell_->AttachChildren();
shell_->SetWindowLevel(level_);
shell_->NotifyWindowRestore();
}