github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove use of banned std::to_string() (#44514)

Browse Source 
Use base::NumberToString() instead

Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned
This commit is contained in:
Charles Kerr
2024-11-04 15:42:42 -06:00
committed by GitHub
parent 1835c0ab6c
commit 24dc9ddf5c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/notifications/win/windows_toast_notification.cc
View File

@@ -664,8 +664,8 @@ IFACEMETHODIMP ToastEventHandler::Invoke(
winui::Notifications::IToastFailedEventArgs* e) {
HRESULT error;
e->get_ErrorCode(&error);
std::string errorMessage =
"Notification failed. HRESULT:" + std::to_string(error);
std::string errorMessage = base::StrCat(
{"Notification failed. HRESULT:", base::NumberToString(error)});
content::GetUIThreadTaskRunner({})->PostTask(
FROM_HERE, base::BindOnce(&Notification::NotificationFailed,
notification_, errorMessage));