github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent print crash on bad deviceName (#21946)

Browse Source 
* fix: prevent print crash on bad deviceName

* address review feedback
This commit is contained in:
Shelley Vohr
2020-01-31 02:49:13 +00:00
committed by GitHub
parent 662b94f46e
commit 2955c67c4e
3 changed files with 44 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/api/web-contents.md
View File

@@ -1260,7 +1260,7 @@ Returns [`PrinterInfo[]`](structures/printer-info.md)
* `silent` Boolean (optional) - Don't ask user for print settings. Default is `false`.
* `printBackground` Boolean (optional) - Prints the background color and image of
the web page. Default is `false`.
* `deviceName` String (optional) - Set the printer device name to use. Default is `''`.
* `deviceName` String (optional) - Set the printer device name to use. Must be the system-defined name and not the 'friendly' name, e.g 'Brother_QL_820NWB' and not 'Brother QL-820NWB'.
* `color` Boolean (optional) - Set whether the printed web page will be in color or grayscale. Default is `true`.
* `margins` Object (optional)
* `marginType` String (optional) - Can be `default`, `none`, `printableArea`, or `custom`. If `custom` is chosen, you will also need to specify `top`, `bottom`, `left`, and `right`.