github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify NativeWindow::FullScreenTransitionState (#46918)

Browse Source 
* refactor: make NativeWindow::fullscreen_transition_state_ private

* refactor: add NativeWindow::is_transitioning_fullscreen() helper

* refactor: remove unused NativeWindow::fullscreen_transition_state()

* refactor: replace NativeWindow::set_fullscreen_transition_state() with NativeWindow::set_is_transitioning_fullscreen()

refactor: remove unused NativeWindow::FullScreenTransitionState
This commit is contained in:
Charles Kerr
2025-05-05 09:28:29 -05:00
committed by GitHub
parent 1f4f1b4afc
commit 2e2776611f
4 changed files with 18 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
shell/browser/native_window.h
View File

@@ -355,13 +355,12 @@ class NativeWindow : public base::SupportsUserData,
// Handle fullscreen transitions.
void HandlePendingFullscreenTransitions();
enum class FullScreenTransitionState { kEntering, kExiting, kNone };
void set_fullscreen_transition_state(FullScreenTransitionState state) {
fullscreen_transition_state_ = state;
constexpr void set_is_transitioning_fullscreen(const bool val) {
is_transitioning_fullscreen_ = val;
}
FullScreenTransitionState fullscreen_transition_state() const {
return fullscreen_transition_state_;
[[nodiscard]] constexpr bool is_transitioning_fullscreen() const {
return is_transitioning_fullscreen_;
}
enum class FullScreenTransitionType { kHTML, kNative, kNone };
@@ -473,8 +472,6 @@ class NativeWindow : public base::SupportsUserData,
std::optional<extensions::SizeConstraints> content_size_constraints_;
std::queue<bool> pending_transitions_;
FullScreenTransitionState fullscreen_transition_state_ =
FullScreenTransitionState::kNone;
FullScreenTransitionType fullscreen_transition_type_ =
FullScreenTransitionType::kNone;
@@ -522,6 +519,8 @@ class NativeWindow : public base::SupportsUserData,
// Is this a modal window.
bool is_modal_ = false;
bool is_transitioning_fullscreen_ = false;
std::list<DraggableRegionProvider*> draggable_region_providers_;
// Observers of this window.