github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-10 07:58:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: child window with nativeWindowOpen should disable node integration (#15213)

Browse Source 
* fix: child window with nativeWindowOpen should disable node integration

* Revert "fix: do not enable node integration in child window if not enabled (#15076)"

This reverts commit 0252d7686c.

This patch is not needed anymore since we are force disabling node integration
for child windows.
This commit is contained in:
Cheng Zhao
2018-10-25 15:31:07 +09:00
committed by GitHub
parent 7a23980f4b
commit 2f3a8ecd42
8 changed files with 36 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/api/browser-window.md
View File

@@ -351,7 +351,8 @@ It creates a new `BrowserWindow` with native properties as set by the `options`.
Console tab. **Note:** This option is currently experimental and may
change or be removed in future Electron releases.
* `nativeWindowOpen` Boolean (optional) - Whether to use native
`window.open()`. Defaults to `false`. **Note:** This option is currently
`window.open()`. Defaults to `false`. Child windows will always have node
integration disabled. **Note:** This option is currently
experimental.
* `webviewTag` Boolean (optional) - Whether to enable the [`<webview>` tag](webview-tag.md).
Defaults to the value of the `nodeIntegration` option. **Note:** The