github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: replace base::StringPrintf() calls with absl::StrFormat() (#46024)

Browse Source 
The former is now a pass-through for the latter and is slated for removal

Xref: https://issues.chromium.org/issues/40241565

https://chromium-review.googlesource.com/c/chromium/src/+/4907781
This commit is contained in:
Charles Kerr
2025-03-14 17:14:32 -05:00
committed by GitHub
parent 3271b82094
commit 30d2fadb28
3 changed files with 17 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
shell/browser/ui/devtools_ui_theme_data_source.cc
View File

@@ -22,6 +22,7 @@
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "net/base/url_util.h"
#include "third_party/abseil-cpp/absl/strings/str_format.h"
#include "ui/base/webui/web_ui_util.h"
#include "ui/color/color_provider.h"
#include "ui/color/color_provider_utils.h"
@@ -157,17 +158,16 @@ void ThemeDataSource::SendColorsCss(
for (ui::ColorId id = start; id < end; ++id) {
const SkColor color = color_provider.GetColor(id);
std::string css_id_to_color_mapping =
base::StringPrintf("%s:%s;", color_css_name.Run(id).c_str(),
ui::ConvertSkColorToCSSColor(color).c_str());
absl::StrFormat("%s:%s;", color_css_name.Run(id),
ui::ConvertSkColorToCSSColor(color));
base::StrAppend(&css_string, {css_id_to_color_mapping});
if (generate_rgb_vars) {
// Also generate a r,g,b string for each color so apps can construct
// colors with their own opacities in css.
const std::string css_rgb_color_str =
color_utils::SkColorToRgbString(color);
const std::string css_id_to_rgb_color_mapping =
base::StringPrintf("%s-rgb:%s;", color_css_name.Run(id).c_str(),
css_rgb_color_str.c_str());
const std::string css_id_to_rgb_color_mapping = absl::StrFormat(
"%s-rgb:%s;", color_css_name.Run(id), css_rgb_color_str);
base::StrAppend(&css_string, {css_id_to_rgb_color_mapping});
}
}