github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Check menu.popup options are an object (#12325)

Browse Source 
* check menu.popup options are an object

* Add a spec for menu.popup options check

* remove stray .only
This commit is contained in:
Shelley Vohr
2018-03-17 06:31:10 +09:00
committed by GitHub
parent 792837bd71
commit 31d688ad3d
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/browser/api/menu.js
View File

@@ -47,6 +47,9 @@ Menu.prototype._init = function () {
}
Menu.prototype.popup = function (options) {
if (options == null || typeof options !== 'object') {
throw new TypeError('Options must be an object')
}
let {window, x, y, positioningItem, callback} = options
// no callback passed