From 3271b820944b3306642c3f7d113415a84ed1b79a Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Fri, 14 Mar 2025 10:59:15 -0500 Subject: [PATCH] refactor: remove unused system header includes (#46015) * chore: remove unused #include * chore: remove unused #include * chore: remove unused #include * chore: remove unused #include * chore: remove unused #include * chore: remove unused #include * chore: remove unused #include * chore: remove unused #include * chore: remove unused #include * chore: iwyu * chore: iwyu --- shell/app/electron_content_client.cc | 1 - shell/app/electron_main_linux.cc | 1 - shell/app/electron_main_win.cc | 1 - shell/browser/api/electron_api_service_worker_main.cc | 1 - shell/browser/api/electron_api_service_worker_main.h | 2 -- shell/browser/api/electron_api_web_contents.h | 2 -- shell/browser/api/gpu_info_enumerator.h | 1 - shell/browser/electron_download_manager_delegate.cc | 1 - shell/browser/electron_web_contents_utility_handler_impl.h | 2 -- .../extensions/api/extension_action/extension_action_api.cc | 1 - .../extensions/api/extension_action/extension_action_api.h | 2 -- shell/browser/extensions/api/scripting/scripting_api.h | 2 +- .../file_system_access/file_system_access_permission_context.h | 1 + shell/browser/javascript_environment.cc | 1 - shell/browser/native_window.h | 1 + shell/browser/net/asar/asar_file_validator.cc | 1 - shell/browser/net/system_network_context_manager.cc | 1 - shell/browser/osr/osr_render_widget_host_view.cc | 1 - shell/browser/relauncher.cc | 2 -- shell/browser/ui/devtools_ui_bundle_data_source.cc | 1 - shell/browser/ui/devtools_ui_theme_data_source.cc | 1 - shell/browser/zoom_level_delegate.cc | 1 - shell/common/process_util.h | 1 - shell/renderer/api/electron_api_context_bridge.cc | 1 - shell/renderer/electron_api_service_impl.cc | 2 -- shell/renderer/electron_render_frame_observer.cc | 2 -- shell/renderer/electron_sandboxed_renderer_client.cc | 1 - .../renderer/extensions/electron_extensions_renderer_client.cc | 2 -- shell/renderer/extensions/electron_extensions_renderer_client.h | 2 -- 29 files changed, 3 insertions(+), 36 deletions(-) diff --git a/shell/app/electron_content_client.cc b/shell/app/electron_content_client.cc index 2748d4df5b..b77a0e4d49 100644 --- a/shell/app/electron_content_client.cc +++ b/shell/app/electron_content_client.cc @@ -6,7 +6,6 @@ #include #include -#include #include #include "base/command_line.h" diff --git a/shell/app/electron_main_linux.cc b/shell/app/electron_main_linux.cc index d12cd55f7e..f4f452ee97 100644 --- a/shell/app/electron_main_linux.cc +++ b/shell/app/electron_main_linux.cc @@ -3,7 +3,6 @@ // found in the LICENSE file. #include -#include #include "base/at_exit.h" #include "base/command_line.h" diff --git a/shell/app/electron_main_win.cc b/shell/app/electron_main_win.cc index 4f89cb5a4c..da0143a9e6 100644 --- a/shell/app/electron_main_win.cc +++ b/shell/app/electron_main_win.cc @@ -14,7 +14,6 @@ #include #include #include -#include #include "base/at_exit.h" #include "base/debug/alias.h" diff --git a/shell/browser/api/electron_api_service_worker_main.cc b/shell/browser/api/electron_api_service_worker_main.cc index 2c397a9e86..4d06cc083a 100644 --- a/shell/browser/api/electron_api_service_worker_main.cc +++ b/shell/browser/api/electron_api_service_worker_main.cc @@ -7,7 +7,6 @@ #include #include #include -#include #include "base/logging.h" #include "base/no_destructor.h" diff --git a/shell/browser/api/electron_api_service_worker_main.h b/shell/browser/api/electron_api_service_worker_main.h index 995f7ad542..7166c6fac0 100644 --- a/shell/browser/api/electron_api_service_worker_main.h +++ b/shell/browser/api/electron_api_service_worker_main.h @@ -5,9 +5,7 @@ #ifndef ELECTRON_SHELL_BROWSER_API_ELECTRON_API_SERVICE_WORKER_MAIN_H_ #define ELECTRON_SHELL_BROWSER_API_ELECTRON_API_SERVICE_WORKER_MAIN_H_ -#include #include -#include #include "base/memory/raw_ptr.h" #include "base/memory/weak_ptr.h" diff --git a/shell/browser/api/electron_api_web_contents.h b/shell/browser/api/electron_api_web_contents.h index 58389913ca..d8e88d7fec 100644 --- a/shell/browser/api/electron_api_web_contents.h +++ b/shell/browser/api/electron_api_web_contents.h @@ -9,8 +9,6 @@ #include #include #include -#include -#include #include #include "base/functional/callback_forward.h" diff --git a/shell/browser/api/gpu_info_enumerator.h b/shell/browser/api/gpu_info_enumerator.h index 7286cb1203..c6fb3d5820 100644 --- a/shell/browser/api/gpu_info_enumerator.h +++ b/shell/browser/api/gpu_info_enumerator.h @@ -5,7 +5,6 @@ #ifndef ELECTRON_SHELL_BROWSER_API_GPU_INFO_ENUMERATOR_H_ #define ELECTRON_SHELL_BROWSER_API_GPU_INFO_ENUMERATOR_H_ -#include #include #include diff --git a/shell/browser/electron_download_manager_delegate.cc b/shell/browser/electron_download_manager_delegate.cc index 2e68b70532..560bf86779 100644 --- a/shell/browser/electron_download_manager_delegate.cc +++ b/shell/browser/electron_download_manager_delegate.cc @@ -6,7 +6,6 @@ #include #include -#include #include #include "base/files/file_util.h" diff --git a/shell/browser/electron_web_contents_utility_handler_impl.h b/shell/browser/electron_web_contents_utility_handler_impl.h index 517c28eaee..78c3ac5936 100644 --- a/shell/browser/electron_web_contents_utility_handler_impl.h +++ b/shell/browser/electron_web_contents_utility_handler_impl.h @@ -5,8 +5,6 @@ #ifndef ELECTRON_SHELL_BROWSER_ELECTRON_WEB_CONTENTS_UTILITY_HANDLER_IMPL_H_ #define ELECTRON_SHELL_BROWSER_ELECTRON_WEB_CONTENTS_UTILITY_HANDLER_IMPL_H_ -#include - #include "base/memory/weak_ptr.h" #include "content/public/browser/global_routing_id.h" #include "content/public/browser/web_contents_observer.h" diff --git a/shell/browser/extensions/api/extension_action/extension_action_api.cc b/shell/browser/extensions/api/extension_action/extension_action_api.cc index 0d32060921..537b0f9d1a 100644 --- a/shell/browser/extensions/api/extension_action/extension_action_api.cc +++ b/shell/browser/extensions/api/extension_action/extension_action_api.cc @@ -6,7 +6,6 @@ #include -#include #include #include "base/no_destructor.h" diff --git a/shell/browser/extensions/api/extension_action/extension_action_api.h b/shell/browser/extensions/api/extension_action/extension_action_api.h index cb8c2634ab..61f9ecbbab 100644 --- a/shell/browser/extensions/api/extension_action/extension_action_api.h +++ b/shell/browser/extensions/api/extension_action/extension_action_api.h @@ -5,8 +5,6 @@ #ifndef SHELL_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_ #define SHELL_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_ -#include - #include "base/memory/raw_ptr.h" #include "extensions/browser/browser_context_keyed_api_factory.h" #include "extensions/browser/extension_action.h" diff --git a/shell/browser/extensions/api/scripting/scripting_api.h b/shell/browser/extensions/api/scripting/scripting_api.h index fe701a55a7..7b1f5b452e 100644 --- a/shell/browser/extensions/api/scripting/scripting_api.h +++ b/shell/browser/extensions/api/scripting/scripting_api.h @@ -7,8 +7,8 @@ #include #include +#include #include -#include #include #include "chrome/common/extensions/api/scripting.h" diff --git a/shell/browser/file_system_access/file_system_access_permission_context.h b/shell/browser/file_system_access/file_system_access_permission_context.h index db60e43210..18d55ad477 100644 --- a/shell/browser/file_system_access/file_system_access_permission_context.h +++ b/shell/browser/file_system_access/file_system_access_permission_context.h @@ -7,6 +7,7 @@ #include "shell/browser/file_system_access/file_system_access_permission_context.h" +#include #include #include #include diff --git a/shell/browser/javascript_environment.cc b/shell/browser/javascript_environment.cc index 1632c31d66..e051083ba4 100644 --- a/shell/browser/javascript_environment.cc +++ b/shell/browser/javascript_environment.cc @@ -6,7 +6,6 @@ #include #include -#include #include #include "base/allocator/partition_alloc_features.h" diff --git a/shell/browser/native_window.h b/shell/browser/native_window.h index f02aa559b4..79d50103d8 100644 --- a/shell/browser/native_window.h +++ b/shell/browser/native_window.h @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include diff --git a/shell/browser/net/asar/asar_file_validator.cc b/shell/browser/net/asar/asar_file_validator.cc index f0f1b9981c..0c9ddf44ee 100644 --- a/shell/browser/net/asar/asar_file_validator.cc +++ b/shell/browser/net/asar/asar_file_validator.cc @@ -6,7 +6,6 @@ #include #include -#include #include #include diff --git a/shell/browser/net/system_network_context_manager.cc b/shell/browser/net/system_network_context_manager.cc index ef75931d15..73cea7fb0b 100644 --- a/shell/browser/net/system_network_context_manager.cc +++ b/shell/browser/net/system_network_context_manager.cc @@ -7,7 +7,6 @@ #include #include #include -#include #include "base/command_line.h" #include "base/memory/raw_ptr.h" diff --git a/shell/browser/osr/osr_render_widget_host_view.cc b/shell/browser/osr/osr_render_widget_host_view.cc index a7bffe3f84..483fd94bbd 100644 --- a/shell/browser/osr/osr_render_widget_host_view.cc +++ b/shell/browser/osr/osr_render_widget_host_view.cc @@ -8,7 +8,6 @@ #include #include #include -#include #include "base/functional/callback_helpers.h" #include "base/location.h" diff --git a/shell/browser/relauncher.cc b/shell/browser/relauncher.cc index f2200d817a..a7b668254c 100644 --- a/shell/browser/relauncher.cc +++ b/shell/browser/relauncher.cc @@ -4,8 +4,6 @@ #include "shell/browser/relauncher.h" -#include - #if BUILDFLAG(IS_WIN) #include #endif diff --git a/shell/browser/ui/devtools_ui_bundle_data_source.cc b/shell/browser/ui/devtools_ui_bundle_data_source.cc index 9f649f98f1..2a73bfeb6e 100644 --- a/shell/browser/ui/devtools_ui_bundle_data_source.cc +++ b/shell/browser/ui/devtools_ui_bundle_data_source.cc @@ -4,7 +4,6 @@ #include "shell/browser/ui/devtools_ui_bundle_data_source.h" -#include #include #include diff --git a/shell/browser/ui/devtools_ui_theme_data_source.cc b/shell/browser/ui/devtools_ui_theme_data_source.cc index f1c78c69ff..6715fdf386 100644 --- a/shell/browser/ui/devtools_ui_theme_data_source.cc +++ b/shell/browser/ui/devtools_ui_theme_data_source.cc @@ -4,7 +4,6 @@ #include "shell/browser/ui/devtools_ui_theme_data_source.h" -#include #include #include #include diff --git a/shell/browser/zoom_level_delegate.cc b/shell/browser/zoom_level_delegate.cc index 5b3838bd94..7dd24f9b51 100644 --- a/shell/browser/zoom_level_delegate.cc +++ b/shell/browser/zoom_level_delegate.cc @@ -4,7 +4,6 @@ #include "shell/browser/zoom_level_delegate.h" -#include #include #include diff --git a/shell/common/process_util.h b/shell/common/process_util.h index c9eb759dd6..49ec597342 100644 --- a/shell/common/process_util.h +++ b/shell/common/process_util.h @@ -6,7 +6,6 @@ #define ELECTRON_SHELL_COMMON_PROCESS_UTIL_H_ #include -#include namespace electron { diff --git a/shell/renderer/api/electron_api_context_bridge.cc b/shell/renderer/api/electron_api_context_bridge.cc index 016d377d13..772591b521 100644 --- a/shell/renderer/api/electron_api_context_bridge.cc +++ b/shell/renderer/api/electron_api_context_bridge.cc @@ -7,7 +7,6 @@ #include #include #include -#include #include #include diff --git a/shell/renderer/electron_api_service_impl.cc b/shell/renderer/electron_api_service_impl.cc index bc41997852..739404631c 100644 --- a/shell/renderer/electron_api_service_impl.cc +++ b/shell/renderer/electron_api_service_impl.cc @@ -4,9 +4,7 @@ #include "electron/shell/renderer/electron_api_service_impl.h" -#include #include -#include #include #include diff --git a/shell/renderer/electron_render_frame_observer.cc b/shell/renderer/electron_render_frame_observer.cc index bf0045ae2d..b735b73b32 100644 --- a/shell/renderer/electron_render_frame_observer.cc +++ b/shell/renderer/electron_render_frame_observer.cc @@ -4,8 +4,6 @@ #include "shell/renderer/electron_render_frame_observer.h" -#include - #include "base/memory/ref_counted_memory.h" #include "base/trace_event/trace_event.h" #include "content/public/renderer/render_frame.h" diff --git a/shell/renderer/electron_sandboxed_renderer_client.cc b/shell/renderer/electron_sandboxed_renderer_client.cc index d98e2b3275..2c985c9a59 100644 --- a/shell/renderer/electron_sandboxed_renderer_client.cc +++ b/shell/renderer/electron_sandboxed_renderer_client.cc @@ -5,7 +5,6 @@ #include "shell/renderer/electron_sandboxed_renderer_client.h" #include -#include #include #include "base/base_paths.h" diff --git a/shell/renderer/extensions/electron_extensions_renderer_client.cc b/shell/renderer/extensions/electron_extensions_renderer_client.cc index 29ecc149a3..cab4a6beb1 100644 --- a/shell/renderer/extensions/electron_extensions_renderer_client.cc +++ b/shell/renderer/extensions/electron_extensions_renderer_client.cc @@ -4,8 +4,6 @@ #include "shell/renderer/extensions/electron_extensions_renderer_client.h" -#include - #include "content/public/renderer/render_thread.h" #include "extensions/common/constants.h" #include "extensions/common/manifest_handlers/background_info.h" diff --git a/shell/renderer/extensions/electron_extensions_renderer_client.h b/shell/renderer/extensions/electron_extensions_renderer_client.h index 7bd4aedef3..2fb3d8f7bb 100644 --- a/shell/renderer/extensions/electron_extensions_renderer_client.h +++ b/shell/renderer/extensions/electron_extensions_renderer_client.h @@ -5,8 +5,6 @@ #ifndef ELECTRON_SHELL_RENDERER_EXTENSIONS_ELECTRON_EXTENSIONS_RENDERER_CLIENT_H_ #define ELECTRON_SHELL_RENDERER_EXTENSIONS_ELECTRON_EXTENSIONS_RENDERER_CLIENT_H_ -#include - #include "extensions/renderer/extensions_renderer_client.h" namespace content {