github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: ensure webcontents is destroyed before its associated browser context.

Browse Source
This commit is contained in:
deepak1556
2018-10-09 02:59:58 +05:30
committed by Jeremy Apthorp
parent a71755e1b6
commit 363aafc25b
4 changed files with 34 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
patches/common/chromium/.patches.yaml
View File

@@ -477,3 +477,10 @@ patches:
Pass RenderProcessHost through to PlatformNotificationService.
This is so Electron can identify which renderer a notification came from.
-
author: deepak1556 <hop2deep@gmail.com>
file: content_browser_main_loop.patch
description: |
Pass idle quit closure for main message loop, so that pending tasks are
run before shutdown. This is required to cleanup WebContents asynchronously
in atom::CommonWebContentsDelegate::ResetManageWebContents.

13
patches/common/chromium/content_browser_main_loop.patch Normal file
View File

@@ -0,0 +1,13 @@
diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index eb942391306e..9111cf18b7fc 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -1571,7 +1571,7 @@ void BrowserMainLoop::MainMessageLoopRun() {
}
base::RunLoop run_loop;
- parts_->PreDefaultMainMessageLoopRun(run_loop.QuitClosure());
+ parts_->PreDefaultMainMessageLoopRun(run_loop.QuitWhenIdleClosure());
run_loop.Run();
#endif
}