From 379bd79de4596b81fc064be6963994ebec96434d Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Tue, 13 Mar 2018 16:18:50 +0900 Subject: [PATCH] Remove unnecessary work when merging options --- lib/browser/guest-window-manager.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/browser/guest-window-manager.js b/lib/browser/guest-window-manager.js index 4c4dc90d07..0e4ae30928 100644 --- a/lib/browser/guest-window-manager.js +++ b/lib/browser/guest-window-manager.js @@ -47,14 +47,14 @@ const mergeBrowserWindowOptions = function (embedder, options) { options.webPreferences = {} } if (embedder.browserWindowOptions != null) { - let parentOptions = {...embedder.browserWindowOptions} + let parentOptions = embedder.browserWindowOptions // if parent's visibility is available, that overrides 'show' flag (#12125) const win = BrowserWindow.fromWebContents(embedder.webContents) if (win != null) { const show = win.isVisible() if (typeof show === 'boolean') { - parentOptions.show = show + parentOptions = {...embedder.browserWindowOptions, show: show} } }