github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: pass rfh instances through to the permission helper (#35467)

Browse Source 
* fix: pass rfh instances through to the permission helper

* refactor: use WeakDocumentPtr instead of frame node id

* fix: handle missing initiator document

* fix: dispatch openExternal event for top level webview navs still

Co-authored-by: Samuel Attard <sattard@salesforce.com>
This commit is contained in:
trop[bot]
2022-08-29 09:52:53 +02:00
committed by GitHub
parent 0ad176fd13
commit 38d408a26b
5 changed files with 38 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_web_contents.cc
View File

@@ -1311,7 +1311,7 @@ void WebContents::EnterFullscreenModeForTab(
auto callback =
base::BindRepeating(&WebContents::OnEnterFullscreenModeForTab,
base::Unretained(this), requesting_frame, options);
permission_helper->RequestFullscreenPermission(callback);
permission_helper->RequestFullscreenPermission(requesting_frame, callback);
}
void WebContents::OnEnterFullscreenModeForTab(