github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-11 16:38:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: make .cc, bootstrapped test funcs inline

Browse Source
This commit is contained in:
Charles Kerr
2018-09-04 01:16:31 -05:00
parent dd7af018cb
commit 3b17400850
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
script/cpplint.js
View File

@@ -11,8 +11,6 @@ const SOURCE_ROOT = path.normalize(path.dirname(__dirname))
const LINTER_PATH = path.join(SOURCE_ROOT, 'vendor', 'depot_tools', 'cpplint.py')
const ROOTS = ['atom', 'brightray'].map(token => path.join(SOURCE_ROOT, token))
const isBootstrapped = () => fs.existsSync(LINTER_PATH)
function callCpplint (filenames, args) {
if (args.verbose) console.log([LINTER_PATH, ...filenames].join(' '))
try {
@@ -55,8 +53,6 @@ async function findFiles (top, test) {
})
}
const isCCFile = filename => filename.endsWith('.cc') || filename.endsWith('.h')
const blacklist = new Set([
['atom', 'browser', 'mac', 'atom_application.h'],
['atom', 'browser', 'mac', 'atom_application_delegate.h'],
@@ -88,7 +84,8 @@ const blacklist = new Set([
].map(tokens => path.join(SOURCE_ROOT, ...tokens)))
async function main () {
if (!isBootstrapped()) {
const isBootstrapped = () => fs.existsSync(LINTER_PATH)
if (!isBootstrapped) {
print('[INFO] Skipping cpplint, dependencies has not been bootstrapped')
return
}
@@ -96,6 +93,7 @@ async function main () {
const args = parseCommandLine()
let filenames = []
const isCCFile = filename => filename.endsWith('.cc') || filename.endsWith('.h')
for (const root of ROOTS) {
const files = await findFiles(root, isCCFile)
filenames.push(...files)