github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: enable microtask queue per window agent (#37189)

Browse Source 
* chore: enable microtask queue per window agent

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* chore: switch policies on context microtask queue

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* fix: ensure node::Environment is valid

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
This commit is contained in:
trop[bot]
2023-02-09 10:31:44 +01:00
committed by GitHub
parent 599833fce2
commit 3c8ce8e85d
19 changed files with 115 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shell/common/api/electron_bindings.cc
View File

@@ -251,9 +251,11 @@ void ElectronBindings::DidReceiveMemoryDump(
std::unique_ptr<memory_instrumentation::GlobalMemoryDump> global_dump) {
v8::Isolate* isolate = promise.isolate();
v8::HandleScope handle_scope(isolate);
gin_helper::MicrotasksScope microtasks_scope(isolate, true);
v8::Context::Scope context_scope(
v8::Local<v8::Context>::New(isolate, context));
v8::Local<v8::Context> local_context =
v8::Local<v8::Context>::New(isolate, context);
gin_helper::MicrotasksScope microtasks_scope(
isolate, local_context->GetMicrotaskQueue(), true);
v8::Context::Scope context_scope(local_context);
if (!success) {
promise.RejectWithErrorMessage("Failed to create memory dump");