github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: crash when renderer process crashes while webview is reloading (#46735)

Browse Source 
WebView uses WebContentsViewChildFrame, which doesn't have a Focus impl
and triggers a fatal NOTREACHED.
This commit is contained in:
wujinli
2025-04-25 16:10:27 +08:00
committed by GitHub
parent 37f8db15e9
commit 3e78bbde6a
3 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shell/browser/api/electron_api_web_contents.cc
View File

@@ -4004,6 +4004,14 @@ void WebContents::ExitPictureInPicture() {
PictureInPictureWindowManager::GetInstance()->ExitPictureInPicture();
}
bool WebContents::ShouldFocusPageAfterCrash(content::WebContents* source) {
// WebView uses WebContentsViewChildFrame, which doesn't have a Focus impl
// and triggers a fatal NOTREACHED.
if (is_guest())
return false;
return true;
}
void WebContents::DevToolsSaveToFile(const std::string& url,
const std::string& content,
bool save_as,

1
shell/browser/api/electron_api_web_contents.h
View File

@@ -709,6 +709,7 @@ class WebContents final : public ExclusiveAccessContext,
content::PictureInPictureResult EnterPictureInPicture(
content::WebContents* web_contents) override;
void ExitPictureInPicture() override;
bool ShouldFocusPageAfterCrash(content::WebContents* source) override;
// InspectableWebContentsDelegate:
void DevToolsSaveToFile(const std::string& url,