github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-02-19 03:14:51 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove menu observer before destroying menu_controller_ (#49648)

Browse Source 
* fix: remove menu observer before destroying menu_controller_

* fix: resolves private inheritance conflict
This commit is contained in:
Keeley Hammond
2026-02-04 07:11:00 -08:00
committed by GitHub
parent 51a9101c3d
commit 431f77ca1c
3 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/api/electron_api_menu.h
View File

@@ -61,6 +61,10 @@ class Menu : public gin::Wrappable<Menu>,
ElectronMenuModel* model() const { return model_.get(); }
protected:
// Remove this instance as an observer from the model. Called by derived
// class destructors to ensure observer is removed before platform-specific
// cleanup that may trigger model callbacks.
void RemoveModelObserver();
// Returns a new callback which keeps references of the JS wrapper until the
// passed |callback| is called.
base::OnceClosure BindSelfToClosure(base::OnceClosure callback);