From 4570330c7be80f22285b374ec6b27149fdc333bc Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Tue, 2 Oct 2018 14:56:09 -0700 Subject: [PATCH] Rename WebContentsDelegate methods https://chromium-review.googlesource.com/c/chromium/src/+/1085427 --- atom/browser/api/atom_api_web_contents.cc | 8 ++------ atom/browser/api/atom_api_web_contents.h | 5 ++--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc index 86e563bcb3..2ebe44e557 100644 --- a/atom/browser/api/atom_api_web_contents.cc +++ b/atom/browser/api/atom_api_web_contents.cc @@ -587,8 +587,8 @@ void WebContents::BeforeUnloadFired(content::WebContents* tab, *proceed_to_fire_unload = true; } -void WebContents::MoveContents(content::WebContents* source, - const gfx::Rect& pos) { +void WebContents::SetContentsBounds(content::WebContents* source, + const gfx::Rect& pos) { Emit("move", pos); } @@ -612,10 +612,6 @@ void WebContents::UpdateTargetURL(content::WebContents* source, Emit("update-target-url", url); } -bool WebContents::IsPopupOrPanel(const content::WebContents* source) const { - return type_ == BROWSER_WINDOW; -} - void WebContents::HandleKeyboardEvent( content::WebContents* source, const content::NativeWebKeyboardEvent& event) { diff --git a/atom/browser/api/atom_api_web_contents.h b/atom/browser/api/atom_api_web_contents.h index 3745bccadd..5951efff7a 100644 --- a/atom/browser/api/atom_api_web_contents.h +++ b/atom/browser/api/atom_api_web_contents.h @@ -314,12 +314,11 @@ class WebContents : public mate::TrackableObject, void BeforeUnloadFired(content::WebContents* tab, bool proceed, bool* proceed_to_fire_unload) override; - void MoveContents(content::WebContents* source, - const gfx::Rect& pos) override; + void SetContentsBounds(content::WebContents* source, + const gfx::Rect& pos) override; void CloseContents(content::WebContents* source) override; void ActivateContents(content::WebContents* contents) override; void UpdateTargetURL(content::WebContents* source, const GURL& url) override; - bool IsPopupOrPanel(const content::WebContents* source) const override; void HandleKeyboardEvent( content::WebContents* source, const content::NativeWebKeyboardEvent& event) override;