mirror of
https://github.com/electron/electron.git
synced 2026-01-08 23:18:06 -05:00
chore: [gn] copy node.dll in addition to node.dll.lib (#13489)
On Windows, you need to link against the `.lib` but the `.dll` needs to be next to the `.exe` at runtime, so we need to copy both.
This commit is contained in:
@@ -77,7 +77,7 @@ action("build_node") {
|
||||
outputs = [ "$target_out_dir/Release/lib/libnode.so" ]
|
||||
}
|
||||
if (is_win) {
|
||||
outputs = [ "$target_out_dir/Release/node.dll" ]
|
||||
outputs = [ "$target_out_dir/Release/node.dll.lib", "$target_out_dir/Release/node.dll" ]
|
||||
}
|
||||
}
|
||||
|
||||
@@ -95,7 +95,7 @@ config("node_config") {
|
||||
"//third_party/electron_node/deps/uv/include",
|
||||
"//third_party/electron_node/deps/cares/include",
|
||||
]
|
||||
libs = node_libs
|
||||
libs = [ node_libs[0] ]
|
||||
cflags_cc = [
|
||||
"-Wno-deprecated-declarations",
|
||||
]
|
||||
|
||||
Reference in New Issue
Block a user