github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: non-client mouse events on WCO-enabled windows (#33202)

Browse Source 
Co-authored-by: clavin <clavin@electronjs.org>
This commit is contained in:
trop[bot]
2022-03-09 16:54:54 -05:00
committed by GitHub
parent 19c3e1c8b7
commit 47f8a13384
4 changed files with 62 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
shell/browser/ui/win/electron_desktop_window_tree_host_win.cc
View File

@@ -99,21 +99,4 @@ bool ElectronDesktopWindowTreeHostWin::GetClientAreaInsets(
return false;
}
bool ElectronDesktopWindowTreeHostWin::HandleMouseEvent(ui::MouseEvent* event) {
// Call the default implementation of this method to get the event to its
// proper handler.
bool handled = views::DesktopWindowTreeHostWin::HandleMouseEvent(event);
// On WCO-enabled windows, we need to mark non-client mouse moved events as
// handled so they don't incorrectly propogate back to the OS.
if (native_window_view_->IsWindowControlsOverlayEnabled() &&
event->type() == ui::ET_MOUSE_MOVED &&
(event->flags() & ui::EF_IS_NON_CLIENT) != 0) {
event->SetHandled();
handled = true;
}
return handled;
}
} // namespace electron

1
shell/browser/ui/win/electron_desktop_window_tree_host_win.h
View File

@@ -36,7 +36,6 @@ class ElectronDesktopWindowTreeHostWin
bool GetDwmFrameInsetsInPixels(gfx::Insets* insets) const override;
bool GetClientAreaInsets(gfx::Insets* insets,
HMONITOR monitor) const override;
bool HandleMouseEvent(ui::MouseEvent* event) override;
private:
NativeWindowViews* native_window_view_; // weak ref