From 4ce7ca6cfb287b2d260a9e873cfcd4fc975fa15c Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Mon, 19 Oct 2020 20:11:30 -0400 Subject: [PATCH] test: disable flaky arm tests (#26046) * tests: disable flaking test on all arm platforms * tests: disable flaky did-change-theme-color tests on WOA --- spec-main/api-service-workers-spec.ts | 4 +++- spec-main/api-web-contents-spec.ts | 3 ++- spec/webview-spec.js | 3 ++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/spec-main/api-service-workers-spec.ts b/spec-main/api-service-workers-spec.ts index 66e15d3ee1..1bef615f47 100644 --- a/spec-main/api-service-workers-spec.ts +++ b/spec-main/api-service-workers-spec.ts @@ -7,6 +7,7 @@ import { v4 } from 'uuid'; import { AddressInfo } from 'net'; import { closeWindow } from './window-helpers'; import { emittedOnce, emittedNTimes } from './events-helpers'; +import { ifdescribe } from './spec-helpers'; const partition = 'service-workers-spec'; const uuid = v4(); @@ -65,7 +66,8 @@ describe('session.serviceWorkers', () => { }); }); - describe('getFromVersionID()', () => { + // TODO (jkleinsc) - reenable this test once https://github.com/electron/electron/issues/26043 is resolved + ifdescribe(!process.arch.includes('arm'))('getFromVersionID()', () => { it('should report the correct script url and scope', async () => { const eventInfo = await emittedOnce(ses.serviceWorkers, 'console-message', () => w.loadURL(`${baseUrl}/index.html`)); const details: Electron.MessageDetails = eventInfo[1]; diff --git a/spec-main/api-web-contents-spec.ts b/spec-main/api-web-contents-spec.ts index d45ce0517b..1586afbe4e 100644 --- a/spec-main/api-web-contents-spec.ts +++ b/spec-main/api-web-contents-spec.ts @@ -1375,7 +1375,8 @@ describe('webContents module', () => { } }); - describe('did-change-theme-color event', () => { + // TODO (jkleinsc) - reenable this test on WOA once https://github.com/electron/electron/issues/26045 is resolved + ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('did-change-theme-color event', () => { afterEach(closeAllWindows); it('is triggered with correct theme color', (done) => { const w = new BrowserWindow({ show: true }); diff --git a/spec/webview-spec.js b/spec/webview-spec.js index 53c7638667..ba33dae4a4 100644 --- a/spec/webview-spec.js +++ b/spec/webview-spec.js @@ -986,7 +986,8 @@ describe(' tag', function () { }); }); - describe('did-change-theme-color event', () => { + // TODO (jkleinsc) - reenable this test on WOA once https://github.com/electron/electron/issues/26045 is resolved + ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('did-change-theme-color event', () => { it('emits when theme color changes', async () => { loadWebView(webview, { src: `file://${fixtures}/pages/theme-color.html`