mirror of
https://github.com/electron/electron.git
synced 2026-01-08 23:18:06 -05:00
chore: bump chromium to 140.0.7261.0 (main) (#47561)
* chore: bump chromium in DEPS to 140.0.7259.0 * chore: update patches * Add fade in animation to Picture-in-Picture windows https://chromium-review.googlesource.com/c/chromium/src/+/6538268 * [v8] Use V8 Apis that don't return JSGlobalObject Refs https://issues.chromium.org/issues/333672197 * chore: IWYU * chore: bump chromium in DEPS to 140.0.7261.0 * chore: update patches * revert: update to siso-chromium image * [v8] Use v8::Object::WrapGlobal() Refs https://chromium-review.googlesource.com/c/chromium/src/+/6650977 * chore: IWYU * chore: fix --trace-startup spec --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>
This commit is contained in:
committed by
GitHub
parent
fa15332587
commit
4f69c5835e
@@ -567,7 +567,14 @@ describe('command line switches', () => {
|
||||
});
|
||||
|
||||
it('creates startup trace', async () => {
|
||||
const rc = await startRemoteControlApp(['--trace-startup=*', `--trace-startup-file=${outputFilePath}`, '--trace-startup-duration=1', '--enable-logging']);
|
||||
// node.async_hooks relies on %trace builtin to log trace points from JS
|
||||
// https://github.com/nodejs/node/blob/8b199eef3dd4de910a6521adc42ae611a62a19e1/lib/internal/trace_events_async_hooks.js#L48-L53
|
||||
// The phase event arg TRACE_EVENT_PHASE_NESTABLE_ASYNC_(BEGIN | END) is not supported in v8_use_perfetto mode
|
||||
// https://source.chromium.org/chromium/chromium/src/+/main:v8/src/builtins/builtins-trace.cc;l=201-216
|
||||
// and leads to the following error: TypeError: Trace event phase must be a number.
|
||||
// TODO: Identify why the error started appearing with roll https://github.com/electron/electron/pull/47561
|
||||
// given both v8_use_perfetto has been enabled before the roll and builtins-trace macro hasn't changed.
|
||||
const rc = await startRemoteControlApp(['--trace-startup="*,-node.async_hooks"', `--trace-startup-file=${outputFilePath}`, '--trace-startup-duration=1', '--enable-logging']);
|
||||
const stderrComplete = new Promise<string>(resolve => {
|
||||
let stderr = '';
|
||||
rc.process.stderr!.on('data', (chunk) => {
|
||||
|
||||
Reference in New Issue
Block a user