From 38016b81442dcfab8bd6be98e918b9b43a508de6 Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Mon, 11 Jul 2016 18:23:33 +0200 Subject: [PATCH] Remove unnecessary >= Windows Vista check --- .../crash_reporter/win/crash_service.cc | 22 +++++++------------ 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/atom/common/crash_reporter/win/crash_service.cc b/atom/common/crash_reporter/win/crash_service.cc index 4563a9202a..5782fd72a3 100644 --- a/atom/common/crash_reporter/win/crash_service.cc +++ b/atom/common/crash_reporter/win/crash_service.cc @@ -239,23 +239,17 @@ bool CrashService::Initialize(const base::string16& application_name, } SECURITY_ATTRIBUTES security_attributes = {0}; - SECURITY_ATTRIBUTES* security_attributes_actual = NULL; + SECURITY_DESCRIPTOR* security_descriptor = + reinterpret_cast( + GetSecurityDescriptorForLowIntegrity()); + DCHECK(security_descriptor != NULL); - if (base::win::GetVersion() >= base::win::VERSION_VISTA) { - SECURITY_DESCRIPTOR* security_descriptor = - reinterpret_cast( - GetSecurityDescriptorForLowIntegrity()); - DCHECK(security_descriptor != NULL); - - security_attributes.nLength = sizeof(security_attributes); - security_attributes.lpSecurityDescriptor = security_descriptor; - security_attributes.bInheritHandle = FALSE; - - security_attributes_actual = &security_attributes; - } + security_attributes.nLength = sizeof(security_attributes); + security_attributes.lpSecurityDescriptor = security_descriptor; + security_attributes.bInheritHandle = FALSE; // Create the OOP crash generator object. - dumper_ = new CrashGenerationServer(pipe_name, security_attributes_actual, + dumper_ = new CrashGenerationServer(pipe_name, &security_attributes, &CrashService::OnClientConnected, this, &CrashService::OnClientDumpRequest, this, &CrashService::OnClientExited, this,