From 54440abc598153bd7e259be4a908f0ecc0b33348 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 12 May 2022 11:39:30 -0500 Subject: [PATCH] Revert "refactor: tell gyp to use c++17 when building with our node" This reverts commit 41a03a5799a8f40f31555d73d20ea865acfcd192. --- script/spec-runner.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/script/spec-runner.js b/script/spec-runner.js index ce16865f10..11502c2da0 100755 --- a/script/spec-runner.js +++ b/script/spec-runner.js @@ -230,13 +230,8 @@ async function runMainProcessElectronTests () { } async function installSpecModules (dir) { - // v8 headers use c++17 so override the gyp default of -std=c++14, - // but don't clobber any other CXXFLAGS that were passed into spec-runner.js - const CXXFLAGS = ['-std=c++17', process.env.CXXFLAGS].filter(x => !!x).join(' '); - const nodeDir = path.resolve(BASE, `out/${utils.getOutDir({ shouldLog: true })}/gen/node_headers`); const env = Object.assign({}, process.env, { - CXXFLAGS, npm_config_nodedir: nodeDir, npm_config_msvs_version: '2019', npm_config_yes: 'true'