github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refractor in completed event in DownloadItem.

Browse Source 
* Rename `completed` to `done`, making it align with Chromium's style.
* Add 'state' in `done` event's result. It can check the download item final
status: cancelled, completed, interrupted.
This commit is contained in:
Haojian Wu
2015-09-21 13:45:42 +08:00
parent 997ac91fe0
commit 57bf0cb615
2 changed files with 40 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
atom/browser/api/atom_api_download_item.cc
View File

@@ -9,6 +9,32 @@
#include "atom/common/node_includes.h"
#include "native_mate/dictionary.h"
namespace mate {
template<>
struct Converter<content::DownloadItem::DownloadState> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
content::DownloadItem::DownloadState state) {
std::string download_state;
switch (state) {
case content::DownloadItem::COMPLETE:
download_state = "completed";
break;
case content::DownloadItem::CANCELLED:
download_state = "cancelled";
break;
case content::DownloadItem::INTERRUPTED:
download_state = "interrputed";
break;
default:
break;
}
return ConvertToV8(isolate, download_state);
}
};
} // namespace mate
namespace atom {
namespace api {
@@ -29,8 +55,10 @@ DownloadItem::~DownloadItem() {
}
void DownloadItem::OnDownloadUpdated(content::DownloadItem* item) {
if (download_item_ == item)
download_item_->IsDone() ? Emit("completed") : Emit("updated");
if (download_item_ == item) {
download_item_->IsDone() ?
Emit("done", item->GetState()) : Emit("updated");
}
}
void DownloadItem::OnDownloadDestroyed(content::DownloadItem* download) {