From 58e0771e479c4ef63f8dd0617cbb6dff9b445d93 Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Fri, 4 Aug 2017 12:12:54 +0300 Subject: [PATCH] Remove base::Value::Get{Buffer,Size} https://codereview.chromium.org/2841623003 --- atom/browser/net/url_request_buffer_job.cc | 4 ++-- atom/common/native_mate_converters/content_converter.cc | 2 +- atom/common/native_mate_converters/v8_value_converter.cc | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/atom/browser/net/url_request_buffer_job.cc b/atom/browser/net/url_request_buffer_job.cc index 19449ef56f..48c9b65019 100644 --- a/atom/browser/net/url_request_buffer_job.cc +++ b/atom/browser/net/url_request_buffer_job.cc @@ -60,8 +60,8 @@ void URLRequestBufferJob::StartAsync(std::unique_ptr options) { } data_ = new base::RefCountedBytes( - reinterpret_cast(binary->GetBuffer()), - binary->GetSize()); + reinterpret_cast(binary->GetBlob().data()), + binary->GetBlob().size()); status_code_ = net::HTTP_OK; net::URLRequestSimpleJob::Start(); } diff --git a/atom/common/native_mate_converters/content_converter.cc b/atom/common/native_mate_converters/content_converter.cc index a43e018147..fd267f72be 100644 --- a/atom/common/native_mate_converters/content_converter.cc +++ b/atom/common/native_mate_converters/content_converter.cc @@ -262,7 +262,7 @@ bool Converter>::FromV8( if (type == "rawData") { base::Value* bytes = nullptr; dict->GetBinary("bytes", &bytes); - (*out)->AppendBytes(bytes->GetBuffer(), bytes->GetSize()); + (*out)->AppendBytes(bytes->GetBlob().data(), bytes->GetBlob().size()); } else if (type == "file") { std::string file; int offset = 0, length = -1; diff --git a/atom/common/native_mate_converters/v8_value_converter.cc b/atom/common/native_mate_converters/v8_value_converter.cc index 93659d318d..a32c3594ad 100644 --- a/atom/common/native_mate_converters/v8_value_converter.cc +++ b/atom/common/native_mate_converters/v8_value_converter.cc @@ -255,8 +255,8 @@ v8::Local V8ValueConverter::ToV8Object( v8::Local V8ValueConverter::ToArrayBuffer( v8::Isolate* isolate, const base::Value* value) const { - const char* data = value->GetBuffer(); - size_t length = value->GetSize(); + const char* data = value->GetBlob().data(); + size_t length = value->GetBlob().size(); if (!disable_node_) { return node::Buffer::Copy(isolate, data, length).ToLocalChecked();